Add option to skip statements that does not match any source root

[pbatko]

Add configuration option not to fail on

throw new RuntimeException(s"No source root found for '$src' (source roots: $fmtSourcePaths)");

in https://github.com/scoverage/scalac-scoverage-plugin/blob/master/scalac-scoverage-plugin/src/main/scala/scoverage/report/BaseReportWriter.scala#L26
but skip these paths instead.

[pbatko]

@sksamuel Any chance on this getting merged as well?

[pbatko]

Thanks!

[pbatko]

@sksamuel What is the expected time of the new release?

[gslowikowski]

This is a workaround for #159 , right? Why are you applying it instead of fixing (merging that PR) the real issue?

[pbatko]

Not sure, probably not. I had some problems with separate test project setup and this was the workaround for me.

[gslowikowski]

Can you write more about it?

[pbatko]

IIRC the $srcRoot was set to test project, but in the $src there were paths from both test and tested project.

[gslowikowski]

Can you share sample project?

[gslowikowski]

So? Who knows, what case is fixed by this?

[pbatko]

I have configuration similar to this. (The approach from scoverage gradle examples didn't work)

    def testProject = ...
    def mainProject = ...

    testProject.scoverage {
      sources = mainProject.extensions.scoverage.sources
      dataDir = mainProject.extensions.scoverage.dataDir
      reportDir = mainProject.extensions.scoverage.reportDir
    }

    //based on org/scoverage/ScoverageExtension.groovy:69 from gradle-scoverage
    def mainSourceSet = testProject.sourceSets.scoverage {
      def original = mainProject.sourceSets.getByName(SourceSet.MAIN_SOURCE_SET_NAME)

      resources.source(original.resources)
      scala.source(original.java)
      scala.source(original.scala)

      compileClasspath += original.compileClasspath + testProject.configurations.scoverage
      runtimeClasspath = it.output + testProject.configurations.scoverage + mainProject.configurations.runtime
    }

    compileScoverageScala {
      onlyIf { false }
    }

    mainProject.testScoverage {
      onlyIf { false }
    }

    mainProject.reportScoverage {
      onlyIf { false }
    }

    mainProject.checkScoverage {
      onlyIf { false }
    }

[gslowikowski]

I don't know Gradle.
Is this all to set mainProject's instrumented sources as sources in testProject? I suspect testProject depends on mainProject and contains tests for that project, right?

[pbatko]

It's as you say. It's not the prettiest, but I wouldn't work without it.

[gslowikowski]

@pbatko, I'm trying to merge your project snippet with Gradle sample and I have problems, since I don't know Gradle. Can you attach, or send me directly complete sample project?

At first sight, Gradle does not set source roots properly, but sets project's base directory as source root (SBT did the same before scoverage/sbt-scoverage@5575925). Do you know, how to fix it in the project?
Additionally, is this line OK, or should there be java.source(original.java)?

[pbatko]

Sorry for late response.

In the snippet above, whole configuration should be wrapped with project('test-project'){...}

I guess setting source root to project's root was working, because later this path is used only to match source file prefix.. Gradle's equivalent to what's sbt plugins is doing would probably be something along these lines:
project.sourceSets.findAll{ true }.collectMany { it.scala.getSrcDirs() }

That line looks definitely suspicious.

[gslowikowski]

@sksamuel, @pbatko

I tried to create a test project from the informations from @pbatko above and this test project, but I cannot merge these into one project, I don't know Gradle.

I asked @maiflai (the Gradle plugin author) for help. He suggests to open an issue in Gradle Scoverage plugin.

[gslowikowski]

A side note. Gradle plugin does not support multiple source roots per project. This was introduced sometime ago (issue #104), but only in Maven and SBT plugins.