Improve tests CC further

Author: f1ames

package.json

@@ -21,7 +21,7 @@
     "coverage": "npm run coverage:generate && npx http-server coverage",
     "coverage:generate": "npm run build && npm run coverage:unit && npm run coverage:bdd && npm run coverage:report",
     "coverage:check": "npm run build && npm run coverage:unit && npm run coverage:bdd && nyc report --check-coverage",
-    "coverage:unit": "nyc --silent npm run test:run:unit",
+    "coverage:unit": "nyc --silent npm run test:run:unit && SCRAMJET_LOG=1 nyc --silent --no-clean npm run test:run:unit -- -m \"trace does not throw\"",
     "coverage:bdd": "nyc --silent --no-clean npm run test:run:bdd",
     "coverage:report": "nyc report --reporter=html",
     "copy": "copyfiles -f test/bdd/features/*.feature build/test/bdd/features && copyfiles -f test/_assets/* build/test/_assets",

src/ifca/ifca-chain.ts

@@ -7,6 +7,13 @@ export class IFCAChain<IN> {
      */
     private chain: Array<IFCA<any, any>> = [];
 
+    /**
+     * @returns {number} Length of the IFCAChain (number of IFCA instances in a chain).
+     */
+    get length(): number {
+        return this.chain.length;
+    }
+
     /**
      * Creates and adds new IFCA to this chain.
      *

src/utils.ts

@@ -9,7 +9,6 @@ const SCRAMJET_LOG = process.env.SCRAMJET_LOG;
  * @param {*} [array] Optional array of objects
  */
 function trace(msg:any, ...array: any[]) {
-    // TODO: make this into a const false on compile
     if (!SCRAMJET_LOG) return;
 
     const date = new Date();

test/unit/ifca/ifca-chain.spec.ts

@@ -0,0 +1,19 @@
+import test from "ava";
+import { IFCA } from "../../../src/ifca";
+import { IFCAChain } from "../../../src/ifca/ifca-chain";
+
+test("Same IFCA instance would not be duplicated on the IFCAChain end when added twice", async (t) => {
+    const ifca = new IFCA<number>({});
+    const ifcaChain = new IFCAChain<number>();
+
+    t.is(ifcaChain.length, 0);
+
+    ifcaChain.add(ifca);
+    ifcaChain.add(ifca);
+
+    t.is(ifcaChain.length, 1);
+
+    ifcaChain.create({});
+
+    t.is(ifcaChain.length, 2);
+});

test/unit/utils.spec.ts

@@ -1,5 +1,5 @@
 import test from "ava";
-import { isAsyncFunction } from "../../src/utils";
+import { isAsyncFunction, trace } from "../../src/utils";
 import { TransformFunction } from "../../src/types";
 
 test("isAsyncFunction correctly detects sync function (function declaration)", t => {
@@ -51,3 +51,9 @@ test.skip("isAsyncFunction correctly detects sync function returning promise", t
 
     t.true(isAsyncFunction(syncPromise));
 });
+
+test("trace does not throw", t => {
+    t.notThrows(() => {
+        trace("foo");
+    });
+});