Feat: update the configuration params for sig circuit as we increase max_num_sig to be greater than 100 (#722)

* update configuration params for sig circuit to support max_sigs = 100

* update params for max_num_sig equals 128

Author: kunxian-xia

zkevm-circuits/src/sig_circuit.rs

@@ -111,10 +111,13 @@ impl<F: Field> SubCircuitConfig<F> for SigCircuitConfig<F> {
 
         // halo2-ecc's ECDSA config
         //
-        // - num_advice: 36
-        // - num_lookup_advice: 17
+        // get the following parameters by running
+        // `cargo test --release --package zkevm-circuits --lib sig_circuit::test::sign_verify --
+        // --nocapture`
+        // - num_advice: 56
+        // - num_lookup_advice: 8
         // - num_fixed: 1
-        // - lookup_bits: 13
+        // - lookup_bits: 19
         // - limb_bits: 88
         // - num_limbs: 3
         //
@@ -123,9 +126,9 @@ impl<F: Field> SubCircuitConfig<F> for SigCircuitConfig<F> {
             meta,
             FpStrategy::Simple,
             &num_advice,
-            &[17],
+            &[8],
             1,
-            13,
+            LOG_TOTAL_NUM_ROWS - 1,
             88,
             3,
             modulus::<Fp>(),
@@ -781,12 +784,12 @@ impl<F: Field> SigCircuit<F> {
 
                 // IMPORTANT: Move to Phase2 before RLC
                 log::info!("before proceeding to the next phase");
-                ctx.print_stats(&["Range"]);
 
                 #[cfg(not(feature = "onephase"))]
                 {
                     // finalize the current lookup table before moving to next phase
                     ecdsa_chip.finalize(&mut ctx);
+                    ctx.print_stats(&["ECDSA context"]);
                     ctx.next_phase();
                 }
 
@@ -843,7 +846,7 @@ impl<F: Field> SigCircuit<F> {
                 let lookup_cells = ecdsa_chip.finalize(&mut ctx);
                 log::info!("total number of lookup cells: {}", lookup_cells);
 
-                ctx.print_stats(&["Range"]);
+                ctx.print_stats(&["ECDSA context"]);
                 Ok(assigned_keccak_values_and_sigs
                     .iter()
                     .map(|a| a.1.clone())

zkevm-circuits/src/sig_circuit/test.rs

@@ -18,11 +18,12 @@ use rand::{Rng, RngCore};
 #[test]
 fn sign_verify() {
     use super::utils::LOG_TOTAL_NUM_ROWS;
+    use crate::sig_circuit::utils::MAX_NUM_SIG;
     use rand::SeedableRng;
     use rand_xorshift::XorShiftRng;
     use sha3::{Digest, Keccak256};
     let mut rng = XorShiftRng::seed_from_u64(1);
-    let max_sigs = [16];
+    let max_sigs = [1, 16, MAX_NUM_SIG];
     for max_sig in max_sigs.iter() {
         log::debug!("testing for {} signatures", max_sig);
         let mut signatures = Vec::new();

zkevm-circuits/src/sig_circuit/utils.rs

@@ -12,10 +12,10 @@ use halo2_proofs::{
 
 // Hard coded parameters.
 // FIXME: allow for a configurable param.
-pub(super) const MAX_NUM_SIG: usize = 32;
-// Each ecdsa signature requires 534042 cells
-// We set CELLS_PER_SIG = 535000 to allows for a few buffer
-pub(super) const CELLS_PER_SIG: usize = 535000;
+pub(super) const MAX_NUM_SIG: usize = 128;
+// Each ecdsa signature requires 456786 cells
+// We set CELLS_PER_SIG = 457000 to allows for a few buffer
+pub(super) const CELLS_PER_SIG: usize = 457000;
 // Total number of rows allocated for ecdsa chip
 pub(super) const LOG_TOTAL_NUM_ROWS: usize = 20;
 // Max number of columns allowed