Skip to content

Commit 3bf9bc2

Browse files
authored
fix return/revert offset/len in handle_return for err cases (privacy-scaling-explorations#1676)
### Description geth_step.error is not enough. It only contains error inside geth trace, only stack err and oog err. Exec_step.error contains all types of err we recovered during parsing trace. This pr will fix some failures of testool, like `CreateOOGFromCallRefunds_d1(SStore_Refund_OoG)_g0_v0` ### Issue Link [_link issue here_] ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update
1 parent 63beeee commit 3bf9bc2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

bus-mapping/src/circuit_input_builder/input_state_ref.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,7 @@ impl<'a> CircuitInputStateRef<'a> {
10441044
if !self.call()?.is_root {
10451045
let (offset, length) = match step.op {
10461046
OpcodeId::RETURN | OpcodeId::REVERT => {
1047-
let (offset, length) = if step.error.is_some()
1047+
let (offset, length) = if exec_step.error.is_some()
10481048
|| (self.call()?.is_create() && self.call()?.is_success)
10491049
{
10501050
(0, 0)

0 commit comments

Comments
 (0)