upgrade Rust toolchain (#1418)

* partial..

* default enable circuit-params

* clippy testool

* clippy aggregator

* remove unused

* cargo update

* fix tests

* fix some default unused

---------

Co-authored-by: lightsing <[email protected]>
Co-authored-by: Akase Haruka <[email protected]>

Author: lispc

Cargo.lock

@@ -44,5 +44,6 @@ zstd-encoder = { package = "encoder", git = "https://github.com/scroll-tech/da-c
 csv = "1.1"
 
 [features]
-default = ["revm-precompile/c-kzg"]
+default = ["revm-precompile/c-kzg", "halo2_proofs/circuit-params"]
+display = []
 print-trace = ["ark-std/print-trace"]

aggregator/Cargo.toml

@@ -132,6 +132,8 @@ impl<const N_SNARKS: usize> BatchCircuit<N_SNARKS> {
 impl<const N_SNARKS: usize> Circuit<Fr> for BatchCircuit<N_SNARKS> {
     type Config = (BatchCircuitConfig<N_SNARKS>, Challenges);
     type FloorPlanner = SimpleFloorPlanner;
+    type Params = ();
+
     fn without_witnesses(&self) -> Self {
         unimplemented!()
     }

aggregator/src/aggregation/circuit.rs

@@ -5468,6 +5468,7 @@ mod tests {
     impl<const L: usize, const R: usize> Circuit<Fr> for DecoderConfigTester<L, R> {
         type Config = (DecoderConfig<L, R>, U8Table, Challenges);
         type FloorPlanner = SimpleFloorPlanner;
+        type Params = ();
 
         fn without_witnesses(&self) -> Self {
             unimplemented!()

aggregator/src/aggregation/decoder.rs

@@ -1127,6 +1127,7 @@ mod tests {
     impl Circuit<Fr> for SeqExecMock {
         type Config = SeqExecMockConfig;
         type FloorPlanner = SimpleFloorPlanner;
+        type Params = ();
         fn without_witnesses(&self) -> Self {
             unimplemented!()
         }

aggregator/src/aggregation/decoder/seq_exec.rs

@@ -2,16 +2,7 @@ use halo2_proofs::{circuit::Value, halo2curves::bn256::Fr};
 
 use super::{FixedLookupTag, FixedLookupValues};
 
-pub struct RomFseTableTransition {
-    /// The block index on the previous FSE table.
-    pub block_idx_prev: u64,
-    /// The block index on the current FSE table.
-    pub block_idx_curr: u64,
-    /// The FSE table previously decoded.
-    pub table_kind_prev: u64,
-    /// The FSE table currently decoded.
-    pub table_kind_curr: u64,
-}
+pub struct RomFseTableTransition;
 
 impl FixedLookupValues for RomFseTableTransition {
     fn values() -> Vec<[Value<Fr>; 7]> {

aggregator/src/aggregation/decoder/tables/fixed/fse_table_transition.rs

@@ -5,16 +5,7 @@ use crate::aggregation::decoder::{
     witgen::FseTableKind,
 };
 
-pub struct RomSeqDataInterleavedOrder {
-    /// FSE table used in the previous bitstring.
-    pub table_kind_prev: FseTableKind,
-    /// FSE table used in the current bitstring.
-    pub table_kind_curr: FseTableKind,
-    /// Boolean flag to indicate whether we are initialising the FSE state.
-    pub is_init_state: bool,
-    /// Boolean flag to indicate whether we are updating the FSE state.
-    pub is_update_state: bool,
-}
+pub struct RomSeqDataInterleavedOrder;
 
 impl FixedLookupValues for RomSeqDataInterleavedOrder {
     fn values() -> Vec<[Value<Fr>; 7]> {

aggregator/src/aggregation/decoder/tables/fixed/seq_data_interleaved_order.rs

@@ -28,22 +28,7 @@ use super::FixedLookupValues;
 ///     - SequenceHeader > FseCode > SequenceData (MOT)
 /// - (0, 0, 1):
 ///     - SequenceHeader > FseCode > SequenceData (MLT)
-pub struct RomSeqTagOrder {
-    /// Boolean flag to mark if LLT is Fse_Compressed_Mode or Predefined_Mode.
-    pub cmode_llt: bool,
-    /// Boolean flag to mark if MOT is Fse_Compressed_Mode or Predefined_Mode.
-    pub cmode_mot: bool,
-    /// Boolean flag to mark if MLT is Fse_Compressed_Mode or Predefined_Mode.
-    pub cmode_mlt: bool,
-    /// Tag that was handled before the current tag.
-    pub tag_prev: ZstdTag,
-    /// Tag currently being handled.
-    pub tag_curr: ZstdTag,
-    /// Tag that will be handled after the current tag.
-    pub tag_next: ZstdTag,
-    /// The FSE table that we expect with the current tag.
-    pub fse_table: FseTableKind,
-}
+pub struct RomSeqTagOrder;
 
 impl FixedLookupValues for RomSeqTagOrder {
     fn values() -> Vec<[Value<Fr>; 7]> {

aggregator/src/aggregation/decoder/tables/fixed/seq_tag_order.rs

@@ -4,18 +4,7 @@ use crate::aggregation::decoder::{tables::fixed::FixedLookupTag, witgen::ZstdTag
 
 use super::FixedLookupValues;
 
-pub struct RomTagTransition {
-    /// The current tag.
-    pub tag: ZstdTag,
-    /// The tag that will be processed after the current tag is finished processing.
-    pub tag_next: ZstdTag,
-    /// The maximum number of bytes that are needed to represent the current tag.
-    pub max_len: u64,
-    /// Whether this tag is processed from back-to-front or not.
-    pub is_reverse: bool,
-    /// Whether this tag belongs to a ``block`` in zstd or not.
-    pub is_block: bool,
-}
+pub struct RomTagTransition;
 
 impl FixedLookupValues for RomTagTransition {
     fn values() -> Vec<[Value<Fr>; 7]> {

aggregator/src/aggregation/decoder/tables/fixed/tag_transition.rs

@@ -1003,6 +1003,7 @@ mod tests {
     impl Circuit<Fr> for SeqTable {
         type Config = SeqInstTable<Fr>;
         type FloorPlanner = SimpleFloorPlanner;
+        type Params = ();
         fn without_witnesses(&self) -> Self {
             unimplemented!()
         }