Updated - got errors in original form (perhaps because of product updates?) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated block->blocks and put the CIDR into a [list]
updated with variable vs static value
removed [ ] - profile is a string, not list
added dns names as output
Move output to output.tf
removed Output after moving to output.tf
replaced IP's with node names to send to loaders
added in var.loader_node_count so # of loaders could be parameter driven
|
Hey Austin! After the summit we forgot to add the new changes from the hackathon... Thanks for that! Is there any change we should make to the documentation for the user who will be running the example or still the same with the new profiles? |
|
@zseta please review |
|
Thanks @ruthea |
zseta
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated terraform Scylla Cloud calls around vpc cidr block->blocks
removed 'max_sstable_age_days': '365' - this is not used in TWCS
Moved aws profilename to variables (hidden in provider before)
change IP's to DNS names (good reference approach)
Made # of loaders/drivers configurable (allows you to scale out the loaders easily if you want a smaller/bigger workload)
Loaders were using the same set of instructions across 3 files - updated to use just one (easier maintenance)
Streamlined the bootstrap of the loaders - loads the inital rows and then goes into a read/write blend.