Skip to content

Commit 67bbd48

Browse files
authored
Merge pull request #366 from scylladb/dk/fix-test_compression_disabled
Fix test_compression_disabled to expect correct value for scylla
2 parents 7e0b02d + 156dde7 commit 67bbd48

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/integration/standard/test_metadata.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
greaterthancass21, assert_startswith, greaterthanorequalcass40,
4141
greaterthanorequaldse67, lessthancass40,
4242
TestCluster, DSE_VERSION, requires_java_udf, requires_composite_type,
43-
requires_collection_indexes, xfail_scylla)
43+
requires_collection_indexes, SCYLLA_VERSION)
4444

4545
from tests.util import wait_until
4646

@@ -531,14 +531,14 @@ def test_collection_indexes(self):
531531
tablemeta = self.get_table_metadata()
532532
self.assertIn('(full(b))', tablemeta.export_as_string())
533533

534-
#TODO: Fix Scylla or test
535-
@xfail_scylla('Scylla prints `compression = {}` instead of `compression = {\'enabled\': \'false\'}`.')
536534
def test_compression_disabled(self):
537535
create_statement = self.make_create_statement(["a"], ["b"], ["c"])
538536
create_statement += " WITH compression = {}"
539537
self.session.execute(create_statement)
540538
tablemeta = self.get_table_metadata()
541-
expected = "compression = {}" if CASSANDRA_VERSION < Version("3.0") else "compression = {'enabled': 'false'}"
539+
expected = "compression = {'enabled': 'false'}"
540+
if SCYLLA_VERSION is not None or CASSANDRA_VERSION < Version("3.0"):
541+
expected = "compression = {}"
542542
self.assertIn(expected, tablemeta.export_as_string())
543543

544544
def test_non_size_tiered_compaction(self):

0 commit comments

Comments
 (0)