Do not retry in FPS.update_firmware_version() if n_positioners is None

sdss · Jan 10, 2023 · 8073e13 · 8073e13
1 parent 1402581
commit 8073e13
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+### 🔧 Fixed
+
+* Only retry `FPS.update_firmware_version()` if `n_positioners` is not `None`. Otherwise a time out is expected.
+
+
 ## 1.3.1 - January 10, 2023
 
 ### ✨ Improved

diff --git a/python/jaeger/fps.py b/python/jaeger/fps.py
@@ -1200,7 +1200,7 @@ async def update_firmware_version(
             log.error("Failed retrieving firmware version.")
             return False
 
-        if get_fw_command.status.timed_out and not is_retry:
+        if get_fw_command.status.timed_out and n_positioners and not is_retry:
             log.warning("GET_FIRMWARE_VERSION timed out. Retrying.")
             return await self.update_firmware_version(positioner_ids, is_retry=True)