Skip to content

Commit 8073e13

Browse files
committed
Do not retry in FPS.update_firmware_version() if n_positioners is None
1 parent 1402581 commit 8073e13

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
### 🔧 Fixed
4+
5+
* Only retry `FPS.update_firmware_version()` if `n_positioners` is not `None`. Otherwise a time out is expected.
6+
7+
38
## 1.3.1 - January 10, 2023
49

510
### ✨ Improved

python/jaeger/fps.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1200,7 +1200,7 @@ async def update_firmware_version(
12001200
log.error("Failed retrieving firmware version.")
12011201
return False
12021202

1203-
if get_fw_command.status.timed_out and not is_retry:
1203+
if get_fw_command.status.timed_out and n_positioners and not is_retry:
12041204
log.warning("GET_FIRMWARE_VERSION timed out. Retrying.")
12051205
return await self.update_firmware_version(positioner_ids, is_retry=True)
12061206

0 commit comments

Comments
 (0)