fixes for transient implicit PROBLEM

Author: gtheler

ChangeLog.md

@@ -1,10 +1,11 @@
 # Current (under development)
 
  * ...
+ * outputs from `WRITE_RESULTS` or `WRITE_MESH` in `vtu` or `vtk` for transient problems create a `.pvd` file
  * instruction `PROBLEM_SOLVE` is not mandatory anymore, now FeenoX can guess where it should be called
  * keyword `READ_DATA` to read variables and vectors from files
  * `PROBLEM` can define `MESH` in a single line without an explicit `READ_MESH` instruction
- * Neo-hookean material model
+ * neo-hookean material model
  * MMS verification for mechanical with both sdef & ldef
  * Saint Venant-Kirchoff material model for ldef
  * large deformation formulation for `mechanical`

Makefile.am

@@ -117,6 +117,7 @@ TESTS_neutron_sn = \
 
 TESTS_thermal = \
         tests/barra.sh \
+        tests/bunny-thermal.sh \
         tests/encased_rod.sh \
         tests/thermal-1d.sh \
         tests/thermal-2d.sh \

doc/syntax-kate.sh

@@ -1,6 +1,11 @@
 #!/bin/sh
 # take the output of this script as a kate syntax definition file for FeenoX
 #
+# KDE 6:
+# mkdir -p $HOME/.local/share/org.kde.syntax-highlighting/syntax/
+# ./syntax-kate.sh > $HOME/.local/share/org.kde.syntax-highlighting/syntax/feenox.xml
+#
+# KDE 5:
 # mkdir -p $HOME/.local/share/katepart5/syntax/
 # ./syntax-kate.sh > $HOME/.local/share/katepart5/syntax/feenox.xml
 #
@@ -88,7 +93,7 @@ cat << EOF
 
     <itemDatas>
       <itemData name="Normal Text" defStyleNum="dsNormal"/>
-      <itemData name="Keyword1" defStyleNum="dsKeyword"/>
+      <itemData name="Keyword1" defStyleNum="dsKeyword" bold="1"/>
       <itemData name="Keyword2" defStyleNum="dsKeyword" color="#003300"/>
       <itemData name="Operator" defStyleNum="dsOperator" color="#666666"/>
       <itemData name="Identifier" defStyleNum="dsOthers" color="#663333" italic="1"/>

src/flow/run.c

@@ -158,7 +158,10 @@ int feenox_run(void) {
         feenox_special_var_value(done_transient) = 1;
       }
 
-      feenox_call(feenox_step(feenox.pde.instruction->next, NULL));
+      // if we have an implicit PROBLEM, then we stay apple
+      if (feenox.pde.instruction != NULL) {
+        feenox_call(feenox_step(feenox.pde.instruction->next, NULL));
+      }
 
 
     } else if (feenox.dae.dimension != 0) {

src/math/function.c

@@ -488,17 +488,26 @@ double feenox_function_eval(function_t *this, const double *const_x) {
 
   // y is the returned value
   double y = 0;
+  double x_copy[this->n_arguments];
+  int copied = 0;
 
   // implicit SOLVE_PROBLEM
   if (this->is_solution && feenox.pde.problem_solved == 0) {
+    if (const_x != NULL) {
+      // we might need to keep a copy of x
+      for (int i = 0; i < this->n_arguments; i++) {
+        x_copy[i] = const_x[i];
+      }
+      copied = 1;
+    }
+    
     if (feenox_instruction_solve_problem(NULL) != FEENOX_OK) {
       feenox_runtime_error();
     }
   }
 
-  
   // if x is null we assume it is a 3d-vector with zeroes
-  const double *x = (const_x != NULL) ? const_x : zero;
+  const double *x = copied ? (x_copy) : ((const_x != NULL) ? const_x : zero);
 
   // check if we need to initialize
   if (this->initialized == 0) {

src/pdes/fem.c

@@ -552,7 +552,7 @@ inline double *feenox_fem_compute_x_at_gauss(element_t *e, unsigned int q, int i
     feenox.fem.current_gauss_type = e->type;
   }
   if ((*x)[q] == NULL) {
-    (*x)[q] = calloc(3, sizeof(double));
+    feenox_check_alloc_null((*x)[q] = calloc(3, sizeof(double)));
   } else if (feenox.fem.cache_J) {
     return (*x)[q];
   }