Use static value for showing git revision, not subprocess (SEA-1484)

Calling subprocess shall be avoided if at all possible

Author: cyrillkuettel

development.ini.example

@@ -45,6 +45,10 @@ retry.attempts = 3
 # debugtoolbar.hosts = 127.0.0.1 ::1
 
 
+# Generated by puppet
+git_revision = 1234
+
+
 # Set your own path here where the files are stored
 
 documents_dir = files

src/privatim/__init__.py

@@ -90,6 +90,9 @@ def profile_pic(request: 'IRequest') -> str:
 
     config.add_request_method(MessageQueue, 'messages', reify=True)
 
+    rev = settings.get('git_revision', '')
+    config.add_request_method(lambda r: rev, 'git_revision', reify=True)
+
     def add_action_menu_entries(
         request: 'IRequest',
         entries: Iterable['Button'],

src/privatim/git_info.py

@@ -6,8 +6,4 @@
 # https://docs.pylonsproject.org/projects/pyramid_cookbook/en/latest
 # /templates/templates.html
 
-from privatim.git_info import get_git_revision_hash
 from markupsafe import Markup   # noqa: F401
-
-
-git_revision = get_git_revision_hash()

src/privatim/helpers.py

@@ -15,12 +15,12 @@
                 <h5 i18n:translate="" class="text-uppercase mb-md-3">
                     Version
                 </h5>
-                <span tal:condition="h.git_revision"
+                <span tal:condition="request.git_revision"
                         data-bs-toggle="tooltip" data-bs-placement="bottom" i18n:attributes="title"
                         title="Version of the software (Git revision number)">
                     <span>Versionsnummer:</span>
                     <span>
-                            ${h.git_revision}
+                            ${request.git_revision}
                     </span>
                 </span>
             </div>