* Install PHPStan using Composer in order to be able to use phpstan/phpstan-strict-rules and tomasvotruba/type-coverage

* Configure phpstan/phpstan-strict-rules, tomasvotruba/type-coverage, and ergebnis/phpstan-rules
* Update PHPStan configuration
* Put Phive binary under version control and manage it through "ant update-tools"

Author: sebastianbergmann

.phive/phars.xml

@@ -2,5 +2,4 @@
 <phive xmlns="https://phar.io/phive">
   <phar name="php-cs-fixer" version="^3.70" installed="3.72.0" location="./tools/php-cs-fixer" copy="true"/>
   <phar name="composer" version="^2.8" installed="2.8.6" location="./tools/composer" copy="true"/>
-  <phar name="phpstan" version="^2.1" installed="2.1.8" location="./tools/phpstan" copy="true"/>
 </phive>

build.xml

@@ -32,10 +32,28 @@
     </target>
 
     <target name="update-tools">
-        <exec executable="phive" taskname="phive">
+        <exec executable="${basedir}/tools/phive">
+            <arg value="--no-progress"/>
+            <arg value="self-update"/>
+        </exec>
+
+        <exec executable="${basedir}/tools/phive">
             <arg value="--no-progress"/>
             <arg value="update"/>
         </exec>
+
+        <exec executable="${basedir}/tools/composer" dir="${basedir}/tools/.phpstan" taskname="composer">
+            <arg value="update"/>
+            <arg value="--no-interaction"/>
+            <arg value="--no-progress"/>
+            <arg value="--no-ansi"/>
+        </exec>
+
+        <exec executable="${basedir}/tools/composer" dir="${basedir}/tools/.phpstan" taskname="composer">
+            <arg value="bump"/>
+            <arg value="--no-interaction"/>
+            <arg value="--no-ansi"/>
+        </exec>
     </target>
 </project>
 

phpstan.neon

@@ -5,11 +5,53 @@ parameters:
         - tests/tests
         - tests/bootstrap.php
 
+    checkTooWideReturnTypesInProtectedAndPublicMethods: true
+    reportAlwaysTrueInLastCondition: true
+    reportPossiblyNonexistentConstantArrayOffset: true
+    reportPossiblyNonexistentGeneralArrayOffset: true
     treatPhpDocTypesAsCertain: false
 
+    strictRules:
+        allRules: false
+        booleansInConditions: true
+        closureUsesThis: true
+        disallowedBacktick: true
+        disallowedEmpty: true
+        disallowedImplicitArrayCreation: true
+        disallowedLooseComparison: true
+        disallowedShortTernary: true
+        illegalConstructorMethodCall: true
+        matchingInheritedMethodNames: true
+        noVariableVariables: true
+        numericOperandsInArithmeticOperators: true
+        overwriteVariablesWithLoop: true
+        requireParentConstructorCall: true
+        strictArrayFilter: true
+        strictFunctionCalls: true
+        switchConditionsMatchingType: true
+        uselessCast: true
+
+    ergebnis:
+        allRules: false
+        final:
+            enabled: true
+            classesNotRequiredToBeAbstractOrFinal:
+                - SebastianBergmann\CodeCoverage\Report\Xml\File
+
+    type_coverage:
+        declare: 100
+        return: 100
+        param: 100
+        property: 100
+        constant: 100
+
     ignoreErrors:
         # Ignore errors caused by defensive programming
         - '#Call to function assert\(\) with true will always evaluate to true.#'
         - '#Call to method .* will always evaluate to true.#'
         - '#Call to method .* will always evaluate to false.#'
         - '#Instanceof between .* and .* will always evaluate to true.#'
+        - '#SebastianBergmann\\CodeCoverage\\Node\\Iterator::current\(\) should be covariant with return type#'
+
+includes:
+	- phar://phpstan.phar/conf/bleedingEdge.neon

tools/.phpstan/composer.json

@@ -0,0 +1,14 @@
+{
+    "require-dev": {
+        "phpstan/phpstan": "^2.1.8",
+        "phpstan/extension-installer": "^1.4.3",
+        "phpstan/phpstan-strict-rules": "^2.0.3",
+        "tomasvotruba/type-coverage": "^2.0.2",
+        "ergebnis/phpstan-rules": "^2.8.0"
+    },
+    "config": {
+        "allow-plugins": {
+            "phpstan/extension-installer": true
+        }
+    }
+}