-
-
Notifications
You must be signed in to change notification settings - Fork 385
Drop DOM dependency in XML Report #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
double check against phpstan-src@05b80ef861 on my macos m4 pro laptop before this PR (using PHPUnit 12.4.4) after this PR |
c9a346b to
b5a8841
Compare
|
Does Infection need the Of course, we would need to expose this as a configuration option. This is just an idea so far. |
great idea. I did some testing and it seems the I also did some perf testing on phpstan-src and I can see a ~15% perf improvement when I think we should tackle this in a separate PR though for this PR here to continue we need a release of the xml-tokenizer including theseer/tokenizer#38 though |
Of course. c1888bb will be released in time for PHPUnit 12.5 which uses this for sebastianbergmann/phpunit@023845a. |
requires theseer/tokenizer#38
before this PR (using PHPUnit 12.4.4)
after this PR:
env