[2.0.2] Not triggering callback when compiling for release

[MrSnoozles]

Hi,

this plugin seems to be working great while developing the app, but stops working as soon as we're compiling for production.

I created a minimal example repository to show the error:
https://github.com/MrSnoozles/demo-nativescript-universal-links

Problem:
The registerUniversalLinkCallback is not evoked when compiling for release.

Steps to see how it works (in development):

• Checkout the repository
• Run with ns run android
• open https://www.beachup.app/share/place/xyz
  -> you should see a console output and an alert

Steps to reproduce the bug (in production):

• Checkout the repository
• Run with ns run android --env.production
• open https://www.beachup.app/share/place/xyz
  -> nothing happens

[MrSnoozles]

Further investigation:
It works in @tralves fork. So if in your package.json you replace @nativescript-community/universal-links with this dependency:
"nativescript-plugin-universal-links": "https://github.com/tralves/nativescript-plugin-universal-links/raw/master/dist/nativescript-plugin-universal-links.tar.gz",

it should work.

[sebestindragos]

Hi @MrSnoozles ,
This project is no longer maintained in this repo, it has been taken over by the NS Community
https://github.com/nativescript-community/universal-links

[MrSnoozles]

Hi,

jipp, I read that. But as it's a forked repo, we can not create issues there. So I thought the next best place to post an issue report would be here. Sorry if it caused any inconvenience.

[asharghi]

Hi @MrSnoozles. I added this in my packages.json:
"nativescript-plugin-universal-links": "https://github.com/tralves/nativescript-plugin-universal-links/raw/master/dist/nativescript-plugin-universal-links.tar.gz"
But when I try to import registerUniversalLinkCallback from nativescript-plugin-universal-links it says: Cannot find module 'nativescript-plugin-universal-links' or its corresponding type declarations.

How did you import registerUniversalLinkCallback?

[PiyushHM]

I am using https://github.com/nativescript-community/universal-links, but facing same issue of 'not triggering callback when compiling for release"

Getting same error as @asharghi when trying to use "nativescript-plugin-universal-links": "https://github.com/tralves/nativescript-plugin-universal-links/raw/master/dist/nativescript-plugin-universal-links.tar.gz"

Need quick help. Please provide fix or workaround if any.

[MrSnoozles]

@asharghi Think I did not do anything else than you.

1. In your projects package.json in the dependencies section add:
   "nativescript-plugin-universal-links": "https://github.com/tralves/nativescript-plugin-universal-links/raw/master/dist/nativescript-plugin-universal-links.tar.gz",
2. Run npm install nativescript-plugin-universal-links
3. in your app, import it: import { registerUniversalLinkCallback } from "nativescript-plugin-universal-links" and use it like in the documentation

Do you get the error from your IDE or during the compilation process?

[PiyushHM]

I followed same steps, but getting error -
Cannot find module 'nativescript-plugin-universal-links' or its corresponding type declarations.

[asharghi]

Did the same. I get the error from VSCode. It builds just fine, but havent run it yet because of some other webpack issue that Igor is looking in to

[PiyushHM]

I am getting error both in vscode as well as during the build.

TS2307: Cannot find module 'nativescript-plugin-universal-links' or its corresponding type declarations.
Executing webpack failed with exit code 2.

Do we need changes in web pack or any other file to make it work ?

[asharghi]

For me it works with adding // @ts-ignore above the import

[asharghi]

Maybe @keerl could be so kind and create a 2.0.3 package with the fix from @tralves fork? :)

[keerl]

Thanks for the tag @asharghi I would have never seen this otherwise. I didn't realize the NS community version didn't have an issues tab so I enabled it here (thanks @MrSnoozles).

I found the issue and just published version 2.0.3 under @nativescript-community/universal-links. Could someone try it out and confirm the issue is fixed?

[PiyushHM]

Yes. The app link callback works properly with 2.0.3.

Thank you so much for the quick response.