Skip to content

Commit 7a5eed9

Browse files
committed
Change auto_commit to False in SimpleConsumer
Also start a change log for important stuff like this Closes dpkp#34
1 parent 64b7578 commit 7a5eed9

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@
44
build
55
dist
66
MANIFEST
7+
env

CHANGES.md

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Notable Changes
2+
3+
* Changing auto_commit to False in [SimpleConsumer](kafka/SimpleConsumer.py), until 0.8.1 is release offset commits are unsupported

kafka/consumer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class SimpleConsumer(object):
3838
these triggers
3939
4040
"""
41-
def __init__(self, client, group, topic, auto_commit=True,
41+
def __init__(self, client, group, topic, auto_commit=False,
4242
auto_commit_every_n=AUTO_COMMIT_MSG_COUNT,
4343
auto_commit_every_t=AUTO_COMMIT_INTERVAL):
4444
self.client = client

0 commit comments

Comments
 (0)