Merge pull request #300 from secretkeylabs/vic/fix-psbt-bug

Fix bug with parsing PSBT and knownEmptyTxids
secretkeylabs · Dec 19, 2024 · 08ee0c2 · 08ee0c2
2 parents c9e9782 + 92033be
commit 08ee0c2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/transactions/bitcoin/enhancedPsbt.ts b/transactions/bitcoin/enhancedPsbt.ts
@@ -5,7 +5,7 @@ import { concatBytes } from 'micro-packed';
 
 import { getRunesClient } from '../../api';
 import { UTXO } from '../../types';
-import { getBtcNetwork, getBtcNetworkDefinition, isInscriptionsAndRunesCompatible } from '../btcNetwork';
+import { getBtcNetworkDefinition, isInscriptionsAndRunesCompatible } from '../btcNetwork';
 import { InputToSign, TransactionContext } from './context';
 import { ExtendedDummyUtxo, ExtendedUtxo } from './extendedUtxo';
 import {
@@ -184,13 +184,14 @@ export class EnhancedPsbt {
     inputTxid: string,
     knownEmptyTxids?: string[],
   ) => {
-    if (knownEmptyTxids && !knownEmptyTxids.includes(inputTxid)) {
+    if (!knownEmptyTxids?.includes(inputTxid)) {
       const addressInput = await this._context.getUtxoFallbackToExternal(`${inputTxid}:${inputRaw.index}`);
       if (addressInput && addressInput.extendedUtxo) {
         return addressInput.extendedUtxo;
       }
     }
 
+    // we know this UTXO won't exist, so we create a dummy one
     const utxo: UTXO = {
       txid: inputTxid,
       vout: inputRaw.index!,