Skip to content

Commit 9a06a52

Browse files
committed
add ecdsa-sha2-nistp521 test data to two other tests
Signed-off-by: NicholasTanz <[email protected]>
1 parent 6d4fe14 commit 9a06a52

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

securesystemslib/signer/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,10 @@
4949
{
5050
("ecdsa", "ecdsa-sha2-nistp256"): SSlibKey,
5151
("ecdsa", "ecdsa-sha2-nistp384"): SSlibKey,
52+
("ecdsa", "ecdsa-sha2-nistp521"): SSlibKey,
5253
("ecdsa-sha2-nistp256", "ecdsa-sha2-nistp256"): SSlibKey,
5354
("ecdsa-sha2-nistp384", "ecdsa-sha2-nistp384"): SSlibKey,
55+
("ecdsa-sha2-nistp521", "ecdsa-sha2-nistp521"): SSlibKey,
5456
("ed25519", "ed25519"): SSlibKey,
5557
("rsa", "rsassa-pss-sha224"): SSlibKey,
5658
("rsa", "rsassa-pss-sha256"): SSlibKey,

tests/test_signer.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ def test_key_verify_signature(self):
8888
"0155661bdf705f621a74f55eef36c9ae041e456141eced7a45d4a1f75ded9ac0"
8989
)
9090
ecdsa_nistp384_pub = "-----BEGIN PUBLIC KEY-----\nMHYwEAYHKoZIzj0CAQYFK4EEACIDYgAEksAG80nLUksODTEUBTPJJPYN0bfxhkrr\n2hlyokfRG4kDYsRRN86vWwxDTW7qhWNZPFhJMJxHmvHsCbLz/IF7hdo8Xv/vRO4M\nVHbwq0fiWznUvkZowHC5fH2EEvNF1R5t\n-----END PUBLIC KEY-----\n"
91+
ecdsa_nistp521_keyid = (
92+
"3dddef3c311b151c5fe12f5fcfa3d9795e2b5fe1a6746c2691befacb13a6af4a"
93+
)
94+
ecdsa_nistp521_pub = "-----BEGIN PUBLIC KEY-----\nMIGbMBAGByqGSM49AgEGBSuBBAAjA4GGAAQBXxFGyw9J9C43woa6huZ3IwrEZhku\neHDNZ1UqnHcFhNYFhM7witKxgv6OUpwlwPsPSUjqcBxkkpay4rT4UTwIP94AdsQL\nq3DQ+BuwrEELjAAMxvQGfoMlLJ5fHM4p4KhlKwpk2HiBQp4r1bjuA6MFq7s5yF0C\nnb9TH+ZZwV5/cjCewxY=\n-----END PUBLIC KEY-----"
9195

9296
key_sig_data = [
9397
(
@@ -175,6 +179,13 @@ def test_key_verify_signature(self):
175179
ecdsa_nistp384_pub,
176180
"30650230747ffab40d894dcacfa2da613a312b2423aa744c7b2365345467819c2af210983c5a7ce6810db995f2e6c90f90f9ad1c023100fdde5013796916af1989b757b64f2fad8496fa7b2b19e9568260868d4a670e6feb123b3337179a4d06b5fbe42b6937fb",
177181
),
182+
(
183+
ecdsa_nistp521_keyid,
184+
"ecdsa",
185+
"ecdsa-sha2-nistp521",
186+
ecdsa_nistp521_pub,
187+
"3081880242019c9621491de75e9b89c4956f6571840528923db953a0fdcf88f9c0221e8c181459af1d9f4e420ad7b971c5c429e457f1f67cfc968c655ea569c3185bfeb2bd943f024201bd2d51bee9ae0bbeb79c99c7bc1758dd256ce7caad9020fb2e2873efc80613826a45b96be25eab11dc521942b92af5820ddde08797d9d6ae236aa54036b41e1152",
188+
),
178189
(
179190
ecdsa_keyid,
180191
"ecdsa-sha2-nistp256",
@@ -189,6 +200,13 @@ def test_key_verify_signature(self):
189200
ecdsa_nistp384_pub,
190201
"30650230747ffab40d894dcacfa2da613a312b2423aa744c7b2365345467819c2af210983c5a7ce6810db995f2e6c90f90f9ad1c023100fdde5013796916af1989b757b64f2fad8496fa7b2b19e9568260868d4a670e6feb123b3337179a4d06b5fbe42b6937fb",
191202
),
203+
(
204+
ecdsa_nistp521_keyid,
205+
"ecdsa-sha2-nistp521",
206+
"ecdsa-sha2-nistp521",
207+
ecdsa_nistp521_pub,
208+
"3081880242019c9621491de75e9b89c4956f6571840528923db953a0fdcf88f9c0221e8c181459af1d9f4e420ad7b971c5c429e457f1f67cfc968c655ea569c3185bfeb2bd943f024201bd2d51bee9ae0bbeb79c99c7bc1758dd256ce7caad9020fb2e2873efc80613826a45b96be25eab11dc521942b92af5820ddde08797d9d6ae236aa54036b41e1152",
209+
),
192210
]
193211
for keyid, keytype, scheme, pub, sig in key_sig_data:
194212
key = Key.from_dict(
@@ -346,19 +364,22 @@ def test_verify_invalid_keytype_scheme(self):
346364
ed25519 = "50a5768a7a577483c28e57a6742b4d2170b9be628a961355ef127c45f2aefdc5"
347365
ecdsa_nistp256 = "-----BEGIN PUBLIC KEY-----\nMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEsYJfSlYU3UlYbGOZfE/yOHkayWWq\nLPR/NeCa83szZmnJGc9wwCRPvJS87K+eDGIhhhKueTyrLqXQqmyHioQbOQ==\n-----END PUBLIC KEY-----\n"
348366
ecdsa_nistp384 = "-----BEGIN PUBLIC KEY-----\nMHYwEAYHKoZIzj0CAQYFK4EEACIDYgAEksAG80nLUksODTEUBTPJJPYN0bfxhkrr\n2hlyokfRG4kDYsRRN86vWwxDTW7qhWNZPFhJMJxHmvHsCbLz/IF7hdo8Xv/vRO4M\nVHbwq0fiWznUvkZowHC5fH2EEvNF1R5t\n-----END PUBLIC KEY-----\n"
367+
ecdsa_nistp521 = "-----BEGIN PUBLIC KEY-----\nMIGbMBAGByqGSM49AgEGBSuBBAAjA4GGAAQBXxFGyw9J9C43woa6huZ3IwrEZhku\neHDNZ1UqnHcFhNYFhM7witKxgv6OUpwlwPsPSUjqcBxkkpay4rT4UTwIP94AdsQL\nq3DQ+BuwrEELjAAMxvQGfoMlLJ5fHM4p4KhlKwpk2HiBQp4r1bjuA6MFq7s5yF0C\nnb9TH+ZZwV5/cjCewxY=\n-----END PUBLIC KEY-----"
349368

350369
test_data = [
351370
# bad keytype / scheme
352371
("ed25519", "rsassa-pss-sha256", rsa),
353372
("ecdsa-sha2-nistp384", "ecdsa-sha2-nistp256", ecdsa_nistp256),
354373
("ecdsa-sha2-nistp256", "ecdsa-sha2-nistp384", ecdsa_nistp384),
374+
("ecdsa-sha2-nistp256", "ecdsa-sha2-nistp521", ecdsa_nistp521),
355375
("rsa", "ed25519", ed25519),
356376
# bad key type (pem formatted keys only)
357377
("rsa", "rsassa-pss-sha256", ecdsa_nistp256),
358378
("ecdsa", "ecdsa-sha2-nistp256", rsa),
359379
# bad curve (ecdsa keys only)
360380
("ecdsa", "ecdsa-sha2-nistp256", ecdsa_nistp384),
361381
("ecdsa", "ecdsa-sha2-nistp384", ecdsa_nistp256),
382+
("ecdsa", "ecdsa-sha2-nistp521", ecdsa_nistp256),
362383
]
363384

364385
for keytype, scheme, val in test_data:

0 commit comments

Comments
 (0)