File tree 4 files changed +20
-5
lines changed
integrations/doubleclick-floodlight
4 files changed +20
-5
lines changed Original file line number Diff line number Diff line change 5
5
** Are there breaking changes in this PR?**
6
6
7
7
8
+ ** Testing**
9
+ <!-- -
10
+
11
+ All PRs must follow the process for change control as outlined in:
12
+ https://segment.atlassian.net/wiki/spaces/GRC/pages/453935287/Reinforcing+Change+Control
13
+
14
+ - Testing completed successfully using <how did you test, environment>; or
15
+ - Testing not required because <explain why you think testing isn't needed>
16
+
17
+ --->
18
+
19
+
8
20
** Any background context you want to provide?**
9
21
10
22
Original file line number Diff line number Diff line change
1
+ 1.5.3 / 2020-09-22
2
+ ==================
3
+
4
+ * remove google_cm param from dcf match tag
5
+ * remove additional unused params
6
+
1
7
1.5.2 / 2020-05-29
2
8
==================
3
9
Original file line number Diff line number Diff line change @@ -31,7 +31,7 @@ var Floodlight = (module.exports = integration('DoubleClick Floodlight')
31
31
)
32
32
. tag (
33
33
'doubleclick id' ,
34
- '<img src="//cm.g.doubleclick.net/pixel?google_cm& google_nid={{ googleNetworkId }}&segment_write_key={{ segmentWriteKey }}&user_id={{ userId }}&anonymous_id={{ anonymousId }}&google_hm={{ partnerProvidedId }}"/>'
34
+ '<img src="//cm.g.doubleclick.net/pixel?google_nid={{ googleNetworkId }}&segment_write_key={{ segmentWriteKey }}&google_hm={{ partnerProvidedId }}"/>'
35
35
) ) ;
36
36
37
37
/**
@@ -49,9 +49,6 @@ Floodlight.prototype.initialize = function() {
49
49
this . load ( 'doubleclick id' , {
50
50
googleNetworkId : this . options . googleNetworkId ,
51
51
segmentWriteKey : this . options . segmentWriteKey ,
52
- // TODO: handle userId being nulls/undefined.
53
- userId : this . analytics . user ( ) . id ( ) ,
54
- anonymousId : this . analytics . user ( ) . anonymousId ( ) ,
55
52
// Hosted match table id https://developers.google.com/authorized-buyers/rtb/cookie-guide#match-table
56
53
partnerProvidedId : btoa ( this . analytics . user ( ) . anonymousId ( ) )
57
54
} ) ;
Original file line number Diff line number Diff line change 1
1
{
2
2
"name" : " @segment/analytics.js-integration-doubleclick-floodlight" ,
3
3
"description" : " The DoubleClick Floodlight analytics.js integration." ,
4
- "version" : " 1.5.2 " ,
4
+ "version" : " 1.5.3 " ,
5
5
"keywords" : [
6
6
" analytics.js" ,
7
7
" analytics.js-integration" ,
You can’t perform that action at this time.
0 commit comments