Braze: Revert error catching (#173)

Author: Gabriel Samson

integrations/appboy/lib/index.js

@@ -255,25 +255,13 @@ Appboy.prototype.identify = function(identify) {
   var phone = identify.phone();
   var traits = clone(identify.traits());
 
-  if (userId) window.appboy.changeUser(userId);
-  if (avatar) {
-    window.appboy.getUser().setAvatarImageUrl(avatar);
-  }
-  if (email) {
-    window.appboy.getUser().setEmail(email);
-  }
-  if (firstName) {
-    window.appboy.getUser().setFirstName(firstName);
-  }
-  if (gender) {
-    window.appboy.getUser().setGender(getGender(gender));
-  }
-  if (lastName) {
-    window.appboy.getUser().setLastName(lastName);
-  }
-  if (phone) {
-    window.appboy.getUser().setPhoneNumber(phone);
-  }
+  window.appboy.changeUser(userId);
+  window.appboy.getUser().setAvatarImageUrl(avatar);
+  window.appboy.getUser().setEmail(email);
+  window.appboy.getUser().setFirstName(firstName);
+  window.appboy.getUser().setGender(getGender(gender));
+  window.appboy.getUser().setLastName(lastName);
+  window.appboy.getUser().setPhoneNumber(phone);
   if (address) {
     window.appboy.getUser().setCountry(address.country);
     window.appboy.getUser().setHomeCity(address.city);
@@ -319,17 +307,6 @@ Appboy.prototype.identify = function(identify) {
     delete traits[key];
   }, reserved);
 
-  // Remove nested hash objects as Braze only supports nested array objects in identify calls
-  // https://segment.com/docs/destinations/braze/#identify
-  each(function(value, key) {
-    if (
-      typeof value === 'object' &&
-      Array.isArray(value)
-    ) {
-      delete traits[key];
-    }
-  }, traits);
-
   each(function(value, key) {
     window.appboy.getUser().setCustomUserAttribute(key, value);
   }, traits);
@@ -348,7 +325,7 @@ Appboy.prototype.group = function(group) {
   var userId = group.userId();
   var groupIdKey = 'ab_segment_group_' + group.groupId();
 
-  if (userId) window.appboy.changeUser(userId);
+  window.appboy.changeUser(userId);
   window.appboy.getUser().setCustomUserAttribute(groupIdKey, true);
 };
 
@@ -379,15 +356,7 @@ Appboy.prototype.track = function(track) {
     delete properties[key];
   }, reserved);
 
-  // Remove nested objects as Braze doesn't support nested objects in tracking calls
-  // https://segment.com/docs/destinations/braze/#track
-  each(function(value, key) {
-    if (value != null && typeof value === 'object') {
-      delete properties[key];
-    }
-  }, properties);
-
-  if (userId) window.appboy.changeUser(userId);
+  window.appboy.changeUser(userId);
   window.appboy.logCustomEvent(eventName, properties);
 };
 
@@ -410,7 +379,7 @@ Appboy.prototype.page = function(page) {
   var eventName = pageEvent.event();
   var properties = page.properties();
 
-  if (userId) window.appboy.changeUser(userId);
+  window.appboy.changeUser(userId);
   window.appboy.logCustomEvent(eventName, properties);
 };
 
@@ -431,7 +400,7 @@ Appboy.prototype.orderCompleted = function(track) {
   var currencyCode = track.currency();
   var purchaseProperties = track.properties();
 
-  if (userId) window.appboy.changeUser(userId);
+  window.appboy.changeUser(userId);
 
   // remove reduntant properties
   del(purchaseProperties, 'products');

integrations/appboy/package.json

@@ -1,12 +1,11 @@
 {
   "name": "@segment/analytics.js-integration-appboy",
   "description": "The Appboy analytics.js integration.",
-  "version": "1.10.3",
+  "version": "1.10.0",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",
     "segment",
-    "Braze",
     "Appboy"
   ],
   "main": "lib/index.js",

integrations/appboy/test/index.test.js

@@ -335,11 +335,10 @@ describe('Appboy', function() {
         );
       });
 
-      it('should handle custom traits of acceptable types and excludes nested hashes', function() {
+      it('should handle custom traits of all types', function() {
         analytics.identify('userId', {
           song: "Who's That Chick?",
           artists: ['David Guetta', 'Rihanna'],
-          details: { nested: 'object' },
           number: 16,
           date: 'Tue Apr 25 2017 14:22:48 GMT-0700 (PDT)'
         });
@@ -408,23 +407,19 @@ describe('Appboy', function() {
         analytics.called(window.appboy.logCustomEvent, 'event');
       });
 
-      it('should send all properties except nested arrays and hashes', function() {
+      it('should send all properties', function() {
         analytics.track('event with properties', {
           nickname: 'noonz',
           spiritAnimal: 'rihanna',
-          best_friend: 'han',
-          number_of_friends: 12,
-          idols: ['beyonce', 'madonna'],
-          favoriteThings: { whiskers: 'on-kittins' }
+          best_friend: 'han'
         });
         analytics.called(
           window.appboy.logCustomEvent,
           'event with properties',
           {
             nickname: 'noonz',
             spiritAnimal: 'rihanna',
-            best_friend: 'han',
-            number_of_friends: 12
+            best_friend: 'han'
           }
         );
       });