Improve UX: Forbidden requests should not redirect to login page (temporalio#2270)

semekh · semekh · commit b35044f4e734 · 2024-08-15T12:41:25.000+03:30
diff --git a/src/lib/utilities/handle-error.ts b/src/lib/utilities/handle-error.ts
@@ -38,7 +38,11 @@ export const handleError = (
   }
 
   if (isForbidden(error) && isBrowser) {
-    window.location.assign(routeForLoginPage(error?.message));
+    toasts.push({
+      variant: 'error',
+      message: 'Forbidden!',
+    });
+    return;
   }
 
   if (isNetworkError(error)) {
@@ -65,7 +69,6 @@ export const handleUnauthorizedOrForbiddenError = (
   }
 
   if (isForbidden(error) && isBrowser) {
-    window.location.assign(routeForLoginPage(msg));
     return;
   }
 };

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,11 @@ export const handleError = (`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`if (isForbidden(error) && isBrowser) {`
`41`		`- window.location.assign(routeForLoginPage(error?.message));`
	`41`	`+ toasts.push({`
	`42`	`+ variant: 'error',`
	`43`	`+ message: 'Forbidden!',`
	`44`	`+ });`
	`45`	`+ return;`
`42`	`46`	`}`
`43`	`47`
`44`	`48`	`if (isNetworkError(error)) {`
`@@ -65,7 +69,6 @@ export const handleUnauthorizedOrForbiddenError = (`
`65`	`69`	`}`
`66`	`70`
`67`	`71`	`if (isForbidden(error) && isBrowser) {`
`68`		`- window.location.assign(routeForLoginPage(msg));`
`69`	`72`	`return;`
`70`	`73`	`}`
`71`	`74`	`};`