fix(dockerfile): Allow Semgrep ellipsis in healthcheck instruction #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had previously been omitted, so the test cases that I've added here failed to parse. When parsing dockerfile patterns, we fall back to parsing them as Bash if they fail to parse as Dockerfile. These examples parsed successfully as Bash, but the trees generated did not match, so these silently failed to match where they should. Test plan: Automated tests.
aryx
approved these changes
Aug 1, 2024
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Aug 2, 2024
…rietary#1950) The relevant grammar changes are in semgrep/ocaml-tree-sitter-semgrep#502 Fixes SAF-1441 Test Plan: Automated tests synced from Pro 69486abd95799e64cc39e1884b59789464abb0b7
aryx
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Aug 2, 2024
…rietary#1950) The relevant grammar changes are in semgrep/ocaml-tree-sitter-semgrep#502 Fixes SAF-1441 Test Plan: Automated tests synced from Pro 69486abd95799e64cc39e1884b59789464abb0b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had previously been omitted, so the test cases that I've added here failed to parse. When parsing dockerfile patterns, we fall back to parsing them as Bash if they fail to parse as Dockerfile. These examples parsed successfully as Bash, but the trees generated did not match, so these silently failed to match where they should.
Test plan: Automated tests.
Security