Skip to content

Commit e6c8356

Browse files
committed
Modify SendGrid class to use getters and setters, let the tests use setters and getters
1 parent 719a66f commit e6c8356

File tree

4 files changed

+938
-1030
lines changed

4 files changed

+938
-1030
lines changed

build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ buildscript {
4545
}
4646

4747
dependencies {
48-
compile 'com.sendgrid:java-http-client:2.3.4'
48+
compile 'com.sendgrid:java-http-client:4.0.0'
4949
compile 'com.fasterxml.jackson.core:jackson-core:2.5.3'
5050
compile 'com.fasterxml.jackson.core:jackson-annotations:2.5.3'
5151
compile 'com.fasterxml.jackson.core:jackson-databind:2.5.3'

src/main/java/com/sendgrid/SendGrid.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,16 @@ public Response makeCall(Request request) throws IOException {
9999
*/
100100
public Response api(Request request) throws IOException {
101101
Request req = new Request();
102-
req.method = request.method;
103-
req.baseUri = this.host;
104-
req.endpoint = "/" + version + "/" + request.endpoint;
105-
req.body = request.body;
106-
req.headers = this.requestHeaders;
107-
req.queryParams = request.queryParams;
102+
req.setMethod(request.getMethod());
103+
req.setBaseUri(this.host);
104+
req.setEndpoint("/" + version + "/" + request.getEndpoint());
105+
req.setBody(request.getBody());
106+
for (Map.Entry <String, String> header : this.requestHeaders.entrySet()) {
107+
req.addHeader(header.getKey(), header.getValue());
108+
}
109+
for (Map.Entry <String, String> queryParam : request.getQueryParams().entrySet()) {
110+
req.addQueryParam(queryParam.getKey(), queryParam.getValue());
111+
}
108112

109113
return makeCall(req);
110114
}

src/test/java/com/sendgrid/MockSendGrid.java

+6-4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import java.io.IOException;
44
import java.util.HashMap;
5+
import java.util.Map;
56

67
public class MockSendGrid extends SendGrid {
78
Request request;
@@ -13,10 +14,11 @@ public MockSendGrid(String apiKey) {
1314
public Response makeCall(Request request) throws IOException {
1415
this.request = request;
1516
Response response = new Response();
16-
response.statusCode = 200;
17-
response.body = "{\"message\":\"success\"}";
18-
response.headers = new HashMap<String, String>();
19-
response.headers.put("Test", "Header");
17+
response.setStatusCode(200);
18+
response.setBody("{\"message\":\"success\"}");
19+
Map<String, String> headers = new HashMap<>();
20+
headers.put("Test", "Header");
21+
response.setHeaders(headers);
2022
return response;
2123
}
2224

0 commit comments

Comments
 (0)