resolve clippy problems, disable bunnies

Author: MartinKavik

examples/auth/src/lib.rs

@@ -62,7 +62,7 @@ impl Page {
         match url.next_path_part() {
             None => {
                 if let Some(user) = user {
-                    send_request_to_top_secret(user.token.clone(), orders)
+                    send_request_to_top_secret(user.token.clone(), orders);
                 };
                 Self::Home
             }

examples/bunnies/Cargo.toml

@@ -6,6 +6,8 @@ edition = "2018"
 
 [lib]
 crate-type = ["cdylib"]
+# https://github.com/leudz/shipyard/issues/129
+path = "src/empty_lib.rs"
 
 [dependencies]
 seed = {path = "../../"}

examples/bunnies/src/empty_lib.rs

@@ -0,0 +1 @@
+

examples/component_builder/src/button.rs

@@ -244,7 +244,7 @@ impl<Ms> Default for Button<Ms> {
 // E.g. `div![Button::new("My button")]`
 impl<Ms> UpdateEl<Ms> for Button<Ms> {
     fn update_el(self, el: &mut El<Ms>) {
-        self.view().update_el(el)
+        self.view().update_el(el);
     }
 }
 

examples/custom_elements/src/lib.rs

@@ -38,7 +38,7 @@ fn update(msg: Msg, model: &mut Model, _: &mut impl Orders<Msg>) {
     match msg {
         Msg::RotateCheckboxState(name) => {
             if name == "checkbox-tristate" {
-                model.checkbox_state = model.checkbox_state.next()
+                model.checkbox_state = model.checkbox_state.next();
             }
         }
         Msg::InputChanged(value) => {

examples/server_integration/client/src/example_d.rs

@@ -70,7 +70,7 @@ pub fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg>) {
             if let Some(controller) = &model.request_controller {
                 controller.disable_timeout().expect("disable timeout");
             }
-            model.status = Status::WaitingForResponse(TimeoutStatus::Disabled)
+            model.status = Status::WaitingForResponse(TimeoutStatus::Disabled);
         }
 
         Msg::Fetched(fetch_result) => {

examples/server_integration/client/src/example_e.rs

@@ -130,12 +130,12 @@ fn clear_file_input() {
         .and_then(|element| element.dyn_into::<web_sys::HtmlInputElement>().ok())
         .map(|file_input| {
             // Note: `file_input.set_files(None)` doesn't work
-            file_input.set_value("")
+            file_input.set_value("");
         });
 }
 
 fn toggle(value: &mut bool) {
-    *value = !*value
+    *value = !*value;
 }
 
 // ------ ------

examples/server_integration/server/src/main.rs

@@ -44,7 +44,7 @@ async fn form(mut form: Multipart) -> String {
         let mut field_bytes: Vec<u8> = Vec::new();
         while let Some(Ok(bytes)) = field.next().await {
             for byte in bytes {
-                field_bytes.push(byte)
+                field_bytes.push(byte);
             }
         }
 
@@ -60,6 +60,7 @@ async fn form(mut form: Multipart) -> String {
     output
 }
 
+#[allow(clippy::unused_async)]
 async fn index() -> Result<NamedFile> {
     Ok(NamedFile::open("./client/index.html")?)
 }

examples/subscribe/src/lib.rs

@@ -86,7 +86,7 @@ fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg>) {
         }
         Msg::StartTimer => {
             model.timer_handle =
-                Some(orders.stream_with_handle(streams::interval(1000, || Msg::OnTick)))
+                Some(orders.stream_with_handle(streams::interval(1000, || Msg::OnTick)));
         }
         Msg::StopTimer => {
             model.timer_handle = None;

examples/tea_component/src/lib.rs

@@ -38,10 +38,10 @@ enum Msg {
 fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg>) {
     match msg {
         Msg::CounterA(msg) => {
-            counter::update(msg, &mut model.counter_a, Msg::CounterChanged, orders)
+            counter::update(msg, &mut model.counter_a, Msg::CounterChanged, orders);
         }
         Msg::CounterB(msg) => {
-            counter::update(msg, &mut model.counter_b, Msg::CounterChanged, orders)
+            counter::update(msg, &mut model.counter_b, Msg::CounterChanged, orders);
         }
         Msg::CounterClicked(counter_id) => log!("CounterClicked", counter_id),
         Msg::CounterChanged(value) => log!("CounterChanged", value),

examples/todomvc/src/lib.rs

@@ -137,7 +137,7 @@ fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg>) {
             let all_todos_completed = data.todos.values().all(|todo| todo.completed);
 
             for (_, todo) in &mut data.todos {
-                todo.completed = !all_todos_completed
+                todo.completed = !all_todos_completed;
             }
         }
 
@@ -176,7 +176,7 @@ fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg>) {
         }
         Msg::EditingTodoTitleChanged(title) => {
             if let Some(ref mut editing_todo) = data.editing_todo {
-                editing_todo.title = title
+                editing_todo.title = title;
             }
         }
         Msg::SaveEditingTodo => {

examples/update_from_js/src/lib.rs

@@ -42,7 +42,9 @@ fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg>) {
                 //
                 // _Note:_ Create an issue in Seed's repo if this solution is not usable for you,
                 // we can find another one or try to integrate some locks.
-                orders.perform_cmd(async { enableClock() });
+                orders.perform_cmd(async {
+                    enableClock();
+                });
             } else {
                 log!("JS is NOT ready!");
             }
@@ -81,11 +83,11 @@ pub fn start() -> Box<[JsValue]> {
 
 fn create_closures_for_js(app: &App<Msg, Model, Node<Msg>>) -> Box<[JsValue]> {
     let js_ready = wrap_in_permanent_closure(enc!((app) move |ready| {
-        app.update(Msg::JsReady(ready))
+        app.update(Msg::JsReady(ready));
     }));
 
     let tick = wrap_in_permanent_closure(enc!((app) move |time| {
-        app.update(Msg::Tick(time))
+        app.update(Msg::Tick(time));
     }));
 
     vec![js_ready, tick].into_boxed_slice()

examples/url/src/lib.rs

@@ -55,7 +55,7 @@ enum Msg {
 fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg>) {
     match msg {
         Msg::UrlChanged(subs::UrlChanged(url)) => {
-            *model = Model::new(url, orders.clone_base_path())
+            *model = Model::new(url, orders.clone_base_path());
         }
         Msg::GoToUrl(url) => {
             orders.request_url(url);
@@ -79,7 +79,7 @@ fn view(model: &Model) -> Node<Msg> {
                             ("x", vec!["1"])
                         ]))
                         .set_hash("hash")
-                        .go_and_load()
+                        .go_and_load();
                 })
             ],
         ],
@@ -102,15 +102,15 @@ fn view(model: &Model) -> Node<Msg> {
             button![
                 "Go to '/' and don't trigger `UrlChanged`",
                 ev(Ev::Click, |_| {
-                    Url::new().go_and_push()
+                    Url::new().go_and_push();
                 })
             ],
         ],
         li![
             button![
                 "Go back",
                 ev(Ev::Click, |_| {
-                    Url::go_back(1)
+                    Url::go_back(1);
                 })
             ],
         ],
@@ -124,7 +124,7 @@ fn view(model: &Model) -> Node<Msg> {
             button![
                 "Go to 'https://example.com'",
                 ev(Ev::Click, |_| {
-                    Url::go_and_load_with_str("https://example.com")
+                    Url::go_and_load_with_str("https://example.com");
                 })
             ],
         ],

examples/websocket/src/server.rs

@@ -83,5 +83,5 @@ fn handle_binary_message(client_id: usize, msg: Message) -> Message {
 
 fn main() {
     // Listen on an address and call the closure for each connection
-    listen("127.0.0.1:9000", |out| Server { out }).unwrap()
+    listen("127.0.0.1:9000", |out| Server { out }).unwrap();
 }

src/app.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::module_name_repetitions)]
+
 use crate::browser::dom::virtual_dom_bridge;
 use crate::browser::{
     service::routing,

src/app/data.rs

@@ -6,7 +6,7 @@ use wasm_bindgen::closure::Closure;
 
 type StoredPopstate = RefCell<Option<Closure<dyn FnMut(web_sys::Event)>>>;
 
-#[allow(clippy::type_complexity)]
+#[allow(clippy::type_complexity, dead_code)]
 pub(crate) struct AppData<Ms: 'static, Mdl> {
     pub model: RefCell<Option<Mdl>>,
     pub(crate) root_el: RefCell<Option<El<Ms>>>,

src/browser/web_socket.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::module_name_repetitions)]
+
 use crate::app::Orders;
 use gloo_file::FileReadError;
 use serde::Serialize;