ci: Merge master back into dev (#440)

* feat: ConfigService for centralizing configuration and simplifying BaseService (#338)

`ConfigService` and its usage. This removes the configuration logic from `BaseService` and keeps it all in one place. Also adds some constants for default configuration.

* release: Update prerelease version to 1.0.2-0 ***NO_CI***

* fix: Sync triggers on external package deployment (#339)

Fix updating of function app settings (SDK call wasn't working) and syncing triggers for function apps running from external package.

* release: Update prerelease version to 1.0.2-1 ***NO_CI***

* ci: fix failing Node 8 builds on windows agent (#345)

Hosted agent roll out a fix that broke our builds:

1. Previously, npm wasn’t getting packaged with the version of node in the tool cache,
ie. npm 5.6.0 should be used alongside Node 8.10.0.

1. The fix is to pin to a later version of Node 8 (e.g. 8.16.1) which comes with npm 6+
- https://nodejs.org/en/download/releases/.
  * This will probably slow the build down a little bit since the agent will have to download
  the version (instead of it being pre-installed), but we'll get the right version of npm for free.

* fix job name

* fix job name restrictiosn

* still trying to get the right job name format

* clean up job name

* release: Update prerelease version to 1.0.2-2 ***NO_CI***

* release: Update prerelease version to 1.0.2-3 ***NO_CI***

* fix: Fix typing errors in ARM params and add interfaces (#347)

* release: Update prerelease version to 1.0.2-4 ***NO_CI***

* fix: Update to support CosmosDB bindings (#350)

Updatings the binding schema that is generated to support the changes made to Cosmos DB

* release: Update prerelease version to 1.0.2-5 ***NO_CI***

* feat: Refactor runtime configuration to allow for non-node runtimes (#348)

- Added `FunctionRuntime` configuration to provider
- Extracting `FunctionRuntime` from `runtime` property of configuration within `ConfigService`
- Refactored node-specific code in ARM template generation

* release: Update prerelease version to 1.0.2-6 ***NO_CI***

* fix: Update GitHub Issue and PR templates (#353)

* release: Update prerelease version to 1.0.2-7 ***NO_CI***

* fix: Sort deployments in descending order and fix APIM arm template (#354)

- Updated parameter name in APIM arm template
- Fixed bug of sorting deployments in ascending order, when it should have been descending. This would have pretty serious consequences, because it means that the comparison of ARM templates would always be targeting the first ever deployment, not the most recent.
- Because the `sort()` function sorts the array in place, this bug was not being detected by the tests. Updated `resourceService` tests to create copies of the array rather than using the original reference when testing the validity of the result.

* release: Update prerelease version to 1.0.2-8 ***NO_CI***

* release: Update patch version to 1.0.2 ***NO_CI***

* ci: Add GitHub workflow to move new issues to "To triage" column (#381)

* build(deps): bump handlebars from 4.1.2 to 4.5.3 (#400)

Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3)

Signed-off-by: dependabot[bot] <[email protected]>

* Fix displayName for cosmosDBTrigger (#399)

* Update bindings.json

Co-authored-by: [email protected] <Serverless Azure Functions>
Co-authored-by: My <[email protected]>
Co-authored-by: Wallace Breza <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ofek Bashan <[email protected]>

Author: 5 people

.github/workflows/main.yml

@@ -0,0 +1,13 @@
+name: "Add new issues to 'To triage' column"
+on:
+  issues:
+    types: [opened]
+jobs:
+  Add_New_Issue_To_Project:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: konradpabjan/[email protected]
+      with:
+        action-token: "${{ secrets.ACCESS_TOKEN }}"
+        project-url: "https://github.com/serverless/serverless-azure-functions/projects/1"
+        column-name: "To triage"

package-lock.json

@@ -16,6 +16,12 @@ interface AppServicePlanParams extends DefaultArmParams {
   appServicePlanReserved: ArmParameter;
 }
 
+interface AppServicePlanParams extends DefaultArmParams {
+  appServicePlanName: ArmParameter;
+  appServicePlanSkuName: ArmParameter;
+  appServicePlanSkuTier: ArmParameter;
+}
+
 export class AppServicePlanResource implements ArmResourceTemplateGenerator {
   public static getResourceName(config: ServerlessAzureConfig) {
     const options: AzureNamingServiceOptions = {

src/armTemplates/resources/appServicePlan.ts

@@ -150,7 +150,6 @@ export class ConfigService {
     if (!providerRegion || providerRegion === awsRegion) {
       config.provider.region = this.serverless.service.provider["location"] || region;
     }
-
     if (!config.provider.stage) {
       config.provider.stage = stage;
     }