Skip to content

Commit 6452df8

Browse files
author
Didier SENMARTIN
committed
Code review
1 parent 15c4381 commit 6452df8

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Diff for: README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -419,13 +419,13 @@ functions:
419419
### Copy dependencies instead of linking
420420

421421
Before final packaging, a link is created in .serverless folder for python dependencies.
422-
If it is not possible to create a symbolic link, dependencies can be copied instead of linked
423-
whith the foloowing option:
422+
If it is not possible for the OS to create a symbolic link, dependencies can be copied,
423+
instead of linked, with the following option:
424424

425425
```yaml
426426
custom:
427427
pythonRequirements:
428-
useFinalCopy: true
428+
useSymlinks: false
429429
```
430430

431431
## Manual invocations

Diff for: index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class ServerlessPythonRequirements {
5858
pipCmdExtraArgs: [],
5959
noDeploy: [],
6060
vendor: '',
61-
useFinalCopy: false,
61+
useSymlinks: true,
6262
},
6363
(this.serverless.service.custom &&
6464
this.serverless.service.custom.pythonRequirements) ||

Diff for: lib/pip.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,7 @@ async function installAllRequirements() {
778778
reqsInstalledAt != symlinkPath
779779
) {
780780
// Windows can't symlink so we have to use junction on Windows
781-
if (this.serverless.service.custom.pythonRequirements.useFinalCopy) {
781+
if (!this.serverless.service.custom.pythonRequirements.useSymlinks) {
782782
fse.copySync(reqsInstalledAt, symlinkPath);
783783
} else if (process.platform == 'win32') {
784784
fse.symlink(reqsInstalledAt, symlinkPath, 'junction');

0 commit comments

Comments
 (0)