fix(Sdk): Fixed the OAuth2AuthenticationSchemeDefinitionBase to make request optional

cdavernas · cdavernas · commit 164c90dd0b84 · 2024-10-11T09:26:35.000+02:00
fix(Solution): Updated packages to latest version

Signed-off-by: Charles d'Avernas &lt;charles.davernas@neuroglia.io&gt;
diff --git a/src/ServerlessWorkflow.Sdk.Builders/ExternalResourceDefinitionBuilder.cs b/src/ServerlessWorkflow.Sdk.Builders/ExternalResourceDefinitionBuilder.cs
@@ -28,7 +28,7 @@ public class ExternalResourceDefinitionBuilder
     /// <summary>
     /// Gets/sets the endpoint at which to get the defined resource
     /// </summary>
-    protected virtual OneOf<EndpointDefinition, Uri>? Endpoint { get; set; }
+    protected virtual EndpointDefinition? Endpoint { get; set; }
 
     /// <inheritdoc/>
     public virtual IExternalResourceDefinitionBuilder WithName(string name)
diff --git a/src/ServerlessWorkflow.Sdk.Builders/ServerlessWorkflow.Sdk.Builders.csproj b/src/ServerlessWorkflow.Sdk.Builders/ServerlessWorkflow.Sdk.Builders.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
 	<VersionPrefix>1.0.0</VersionPrefix>
-	<VersionSuffix>alpha2.16</VersionSuffix>
+	<VersionSuffix>alpha3</VersionSuffix>
 	<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
 	<FileVersion>$(VersionPrefix)</FileVersion>
 	<NeutralLanguage>en</NeutralLanguage>
diff --git a/src/ServerlessWorkflow.Sdk.IO/ServerlessWorkflow.Sdk.IO.csproj b/src/ServerlessWorkflow.Sdk.IO/ServerlessWorkflow.Sdk.IO.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
 	<VersionPrefix>1.0.0</VersionPrefix>
-	<VersionSuffix>alpha2.16</VersionSuffix>
+	<VersionSuffix>alpha3</VersionSuffix>
 	<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
 	<FileVersion>$(VersionPrefix)</FileVersion>
 	<NeutralLanguage>en</NeutralLanguage>
diff --git a/src/ServerlessWorkflow.Sdk/Models/Authentication/OAuth2AuthenticationSchemeDefinitionBase.cs b/src/ServerlessWorkflow.Sdk/Models/Authentication/OAuth2AuthenticationSchemeDefinitionBase.cs
@@ -43,7 +43,7 @@ public abstract record OAuth2AuthenticationSchemeDefinitionBase
     /// Gets/sets the configuration of the authentication request to perform
     /// </summary>
     [DataMember(Name = "request", Order = 4), JsonPropertyName("request"), JsonPropertyOrder(4), YamlMember(Alias = "request", Order = 4)]
-    public virtual OAuth2AuthenticationRequestDefinition Request { get; set; } = new();
+    public virtual OAuth2AuthenticationRequestDefinition? Request { get; set; }
 
     /// <summary>
     /// Gets/sets a list, if any, that contains valid issuers that will be used to check against the issuer of generated tokens
diff --git a/src/ServerlessWorkflow.Sdk/Models/ErrorCatcherDefinition.cs b/src/ServerlessWorkflow.Sdk/Models/ErrorCatcherDefinition.cs
@@ -51,10 +51,7 @@ public record ErrorCatcherDefinition
     public virtual RetryPolicyDefinition? Retry
     {
         get => this.RetryValue?.T1Value;
-        set
-        {
-            this.RetryValue = value;
-        }
+        set => this.RetryValue = value!;
     }
 
     /// <summary>
@@ -64,11 +61,7 @@ public virtual RetryPolicyDefinition? Retry
     public virtual string? RetryReference
     {
         get => this.RetryValue?.T2Value;
-        set
-        {
-            ArgumentException.ThrowIfNullOrWhiteSpace(value);
-            this.RetryValue = value;
-        }
+        set => this.RetryValue = value!;
     }
 
     /// <summary>
diff --git a/src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj b/src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
 	<VersionPrefix>1.0.0</VersionPrefix>
-	<VersionSuffix>alpha2.16</VersionSuffix>
+	<VersionSuffix>alpha3</VersionSuffix>
 	<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
 	<FileVersion>$(VersionPrefix)</FileVersion>
 	<NeutralLanguage>en</NeutralLanguage>
@@ -33,10 +33,10 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="11.9.2" />
-	<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
-	<PackageReference Include="Microsoft.Extensions.Http" Version="8.0.0" />
-    <PackageReference Include="Neuroglia.Serialization.YamlDotNet" Version="4.15.4" />
+    <PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="11.10.0" />
+	<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
+	<PackageReference Include="Microsoft.Extensions.Http" Version="8.0.1" />
+    <PackageReference Include="Neuroglia.Serialization.YamlDotNet" Version="4.15.6" />
     <PackageReference Include="Semver" Version="2.3.0" />
   </ItemGroup>
 
diff --git a/tests/ServerlessWorkflow.Sdk.UnitTests/ServerlessWorkflow.Sdk.UnitTests.csproj b/tests/ServerlessWorkflow.Sdk.UnitTests/ServerlessWorkflow.Sdk.UnitTests.csproj
@@ -14,9 +14,9 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="FluentAssertions" Version="6.12.0" />
+    <PackageReference Include="FluentAssertions" Version="6.12.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
-    <PackageReference Include="xunit" Version="2.9.0" />
+    <PackageReference Include="xunit" Version="2.9.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,7 @@ public record ErrorCatcherDefinition`
`51`	`51`	`public virtual RetryPolicyDefinition? Retry`
`52`	`52`	`{`
`53`	`53`	`get => this.RetryValue?.T1Value;`
`54`		`- set`
`55`		`- {`
`56`		`- this.RetryValue = value;`
`57`		`- }`
	`54`	`+ set => this.RetryValue = value!;`
`58`	`55`	`}`
`59`	`56`
`60`	`57`	`/// <summary>`
`@@ -64,11 +61,7 @@ public virtual RetryPolicyDefinition? Retry`
`64`	`61`	`public virtual string? RetryReference`
`65`	`62`	`{`
`66`	`63`	`get => this.RetryValue?.T2Value;`
`67`		`- set`
`68`		`- {`
`69`		`- ArgumentException.ThrowIfNullOrWhiteSpace(value);`
`70`		`- this.RetryValue = value;`
`71`		`- }`
	`64`	`+ set => this.RetryValue = value!;`
`72`	`65`	`}`
`73`	`66`
`74`	`67`	`/// <summary>`