This crate fails to build if the serde derive feature is enabled.

[Emmanuel32]

I tried this:

I was trying to use this crate while also importing serde with the derive feature enabled.

This happened:

The simplest reproduction is running cargo build --workspace --all-targets --features "serde/derive" which returns these errors

error[E0252]: the name `Deserialize` is defined multiple times
 --> core/src/models/map.rs:2:20
  |
1 | use serde::{Serialize, Deserialize};
  |                        ----------- previous import of the macro `Deserialize` here
2 | use serde_derive::{Deserialize, Serialize};
  |                    ^^^^^^^^^^^--
  |                    |
  |                    `Deserialize` reimported here
  |                    help: remove unnecessary import
  |
  = note: `Deserialize` must be defined only once in the macro namespace of this module

error[E0252]: the name `Serialize` is defined multiple times
 --> core/src/models/map.rs:2:33
  |
1 | use serde::{Serialize, Deserialize};
  |             --------- previous import of the macro `Serialize` here
2 | use serde_derive::{Deserialize, Serialize};
  |                                 ^^^^^^^^^ `Serialize` reimported here
  |
  = note: `Serialize` must be defined only once in the macro namespace of this module

I expected this:

No response

Is there a workaround?

One way to fix this is to fully qualify all the instances of Serialize and Deserialize in core/src/models/map.rs as serde::Serialize or serde_derive::Serialize.

Anything else?

cargo build --workspace --all-targets --features "serde/derive" could be added to the github actions to check for this bug.

Platform(s)

No response

Community Notes

• Please vote by adding a 👍 reaction to the issue to help us prioritize.
• If you are interested to work on this issue, please leave a comment.name: Bug Report 🐞

[cdavernas]

Hi @Emmanuel32 and thanks for reporting!

Sorry about that issue, I'm pretty new to Rust. Hell, I didn't even know about the ability to enable features build wise 😛

I'll fix that tomorrow morning!

PS: Don't hesitate to show support to the project by dropping a star! Is always appreciated and, well, you'd be the first ^^