Skip to content

Commit d8d626a

Browse files
committed
BulkSMS: replace isValidNumberForRegion with isValidNumber
1 parent 8c4dbf3 commit d8d626a

File tree

4 files changed

+57
-207
lines changed

4 files changed

+57
-207
lines changed

composer.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,25 @@
1111
"prepend-autoloader": false
1212
},
1313
"description": "Sms77.io API module for PrestaShop applications.",
14-
"homepage": "https://github.com/sms77io/prestashop-api",
14+
"homepage": "https://github.com/sms77io/prestashop-module",
1515
"keywords": [
1616
"prestashop",
1717
"sms"
1818
],
1919
"license": "MIT",
2020
"minimum-stability": "dev",
21-
"name": "sms77/prestashop-api",
21+
"name": "sms77/prestashop-module",
2222
"prefer-stable": true,
2323
"require": {
2424
"php": ">=5.6.0",
25-
"sms77/api": "^1.0",
25+
"sms77/api": "dev-master",
2626
"giggsey/libphonenumber-for-php": "^8.11"
27-
}
27+
},
2828
"support": {
2929
"email": "[email protected]",
3030
"rss": "https://www.sms77.io/de/feed/",
31-
"source": "https://github.com/sms77io/prestashop-api",
32-
"docs": "https://github.com/sms77io/prestashop-api"
31+
"source": "https://github.com/sms77io/prestashop-module",
32+
"docs": "https://github.com/sms77io/prestashop-module"
3333
},
3434
"type": "prestashop-module"
3535
}

composer.lock

-192
This file was deleted.

sms77.php

+7-9
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,12 @@ public function getContent()
179179
if (Tools::isSubmit('submit' . $this->name)) {
180180
foreach (Tools::getValue('config') as $k => $v) {
181181
if ('SMS77_API_KEY' === $k && 0 === Tools::strlen($v)) {
182-
$this->errors[] =
183-
Tools::displayError($this->l(
184-
'An API key is required in order to send SMS. Get yours at sms77.io.'
185-
));
182+
$this->errors[] = Tools::displayError($this->l(
183+
'An API key is required in order to send SMS. Get yours at http://sms77.io.'
184+
));
186185
}
187186

188-
if ('SMS77_ON_GENERIC' === $k) {
187+
if ('SMS77_ON_GENERIC' === $k && Tools::strlen($v)) {
189188
$addresses = self::dbQuery(
190189
'id_country, id_customer, phone, phone_mobile',
191190
'address',
@@ -208,7 +207,6 @@ public function getContent()
208207
$numbers[] = $d['phone_mobile'];
209208
}
210209

211-
212210
$numbers = array_filter($numbers, function ($number) use ($d) {
213211
try {
214212
$isoCode = self::dbQuery(
@@ -217,7 +215,7 @@ public function getContent()
217215
'q.id_country = ' . $d['id_country']);
218216
$isoCode = array_shift($isoCode)['iso_code'];
219217
$numberProto = $this->phoneNumberUtil->parse($number, $isoCode);
220-
return $this->phoneNumberUtil->isValidNumberForRegion($numberProto, $isoCode);
218+
return $this->phoneNumberUtil->isValidNumber($numberProto);
221219
} catch (NumberParseException $e) {
222220
return false;
223221
}
@@ -241,9 +239,9 @@ public function getContent()
241239
}, $valids);
242240
$this->validateAndSend($k, implode(',', array_unique($phoneNumbers)));
243241
}
242+
} else {
243+
Configuration::updateValue($k, $v);
244244
}
245-
246-
Configuration::updateValue($k, $v);
247245
}
248246
}
249247

vendor/composer/installed.json

+44
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,50 @@
120120
],
121121
"description": "Locale functions required by libphonenumber-for-php"
122122
},
123+
{
124+
"name": "mervick/emojionearea",
125+
"version": "v3.4.1",
126+
"version_normalized": "3.4.1.0",
127+
"source": {
128+
"type": "git",
129+
"url": "https://github.com/mervick/emojionearea.git",
130+
"reference": "dc73dc556fdc6e82c5d26847533b893ece255ce1"
131+
},
132+
"dist": {
133+
"type": "zip",
134+
"url": "https://api.github.com/repos/mervick/emojionearea/zipball/dc73dc556fdc6e82c5d26847533b893ece255ce1",
135+
"reference": "dc73dc556fdc6e82c5d26847533b893ece255ce1",
136+
"shasum": ""
137+
},
138+
"time": "2018-02-09T22:44:43+00:00",
139+
"type": "plugin",
140+
"extra": {
141+
"asset-installer-paths": {
142+
"npm-asset-library": "vendor/npm",
143+
"bower-asset-library": "vendor/bower"
144+
}
145+
},
146+
"installation-source": "dist",
147+
"notification-url": "https://packagist.org/downloads/",
148+
"license": [
149+
"MIT"
150+
],
151+
"authors": [
152+
{
153+
"name": "Andrey Izman",
154+
"email": "[email protected]"
155+
},
156+
{
157+
"name": "Klas Lundberg",
158+
"email": "[email protected]"
159+
},
160+
{
161+
"name": "Merlin Mason",
162+
"email": "[email protected]"
163+
}
164+
],
165+
"description": "WYSIWYG-like EmojiOne Converter / Picker Plugin for jQuery"
166+
},
123167
{
124168
"name": "sms77/api",
125169
"version": "dev-master",

0 commit comments

Comments
 (0)