virtual member override bug

[mosioc]

Describe the bug

• non-virtual member function marked 'override' hides virtual member function void *registerOutputVector
• only virtual member functions can be marked 'override' void setVectorAttribute
  => both in: \quisp\quisp\test_utils\StaticEnv.h

To Reproduce
Steps to reproduce the behavior:
bulding with OMNeT++

Expected behavior
Build!

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [Windows 11 Build 27842.1000]
• QuISP version [commit number]
• OMNeT++ version [6.1]
• Eigen version [-]
• Compiler or other build info [-]

Additional context
Add any other context about the problem here.

[Naphann]

I can't seem to be able to reproduce what you mentioned and the code seems to build fine. Can you add more context?

What are the error messages that you got when trying to build the project?

[pfittipaldi]

Hi @Naphann , I also encountered this problem and investigated a bit.

It seems the omnetpp people are in the process of modifying (relevant commit) the cEnvir API, and they changed the prototype of the cEnvir::registerOutputVector function, which the quisp test utils reimplement (include/omnetpp/cenvir.h, line 699 on the commit, 705 now).

[mosioc]

Hi @Naphann , I also encountered this problem and investigated a bit.

It seems the omnetpp people are in the process of modifying (relevant commit) the cEnvir API, and they changed the prototype of the cEnvir::registerOutputVector function, which the quisp test utils reimplement (include/omnetpp/cenvir.h, line 699 on the commit, 705 now).

Hey @pfittipaldi. Yep, I had checked this before but I forgot to leave a comment here. Thanks for pointing it out.

[Naphann]

Thanks for the context. Is the issue only occurred when you use local installation?
I believe the API changes was after 6.1? And we want to keep it simple for the docker users.

If you do local install, I'd probably suggest using 6.0 for now and when we do update the dockerfile we can change the code.
In the meantime, we can update a note for the local installation.