Fix invalid extraction directory error in install script #83
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
marcelroed
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes an installation script issue by ensuring the extraction directory exists before unzipping the CLI binary.
- Added
mkdir "${TMPDIR}/dist"command ininstall.shto create the destination directory before extraction - Addresses issue Install script failing on
unzipcommand on MacOS 15.4 #82 where the unzip command was failing with "Invalid extraction directory" error on MacOS 15.4 - Prevents installation failures that occurred because the unzip command on MacOS requires the destination directory to exist beforehand
- Simple but critical fix that improves cross-platform compatibility of the installation process
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -113,6 +113,7 @@ if ! unzip -t "${TMPDIR}/${BINARY_NAME}.zip" >/dev/null 2>&1; then | |||
| fi | |||
|
|
|||
| # Extract the zip file in the temporary directory. | |||
| mkdir "${TMPDIR}/dist" | |||
There was a problem hiding this comment.
style: Consider adding error handling to the mkdir command similar to other commands in this script.
Suggested change
| mkdir "${TMPDIR}/dist" | |
| mkdir "${TMPDIR}/dist" || { echo "Failed to create extraction directory"; exit 1; } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82 by adding an
mkdirbefore trying to extract the downloaded zip file.