Check published types in CI (#1702)

* Check published types in CI

* Dedupe dependencies

---------

Co-authored-by: Alexey Romanov <[email protected]>

Author: alexeyr-ci

.github/workflows/lint-js-and-ruby.yml

@@ -87,6 +87,11 @@ jobs:
       run: yarn start format.listDifferent
     - name: Type-check TypeScript
       run: yarn run type-check
+    - name: Lint package publishing
+      # --profile because we don't care about node10
+      # --ignore-rules CJS default export can't be resolved at the moment,
+      # revisit in 15.0.0
+      run: yarn run attw --pack . --profile node16 --ignore-rules cjs-only-exports-default
     # We only download and run Actionlint if there is any difference in GitHub Action workflows
     # https://github.com/rhysd/actionlint/blob/main/docs/usage.md#on-github-actions
     - name: Check for GitHub Actions changes

knip.ts

@@ -24,6 +24,8 @@ const config: KnipConfig = {
         // though we don't actually use its rules anywhere.
         'eslint-plugin-jsx-a11y',
         'eslint-plugin-react',
+        // Used in CI
+        '@arethetypeswrong/cli',
       ],
     },
     'spec/dummy': {

package.json

@@ -2,7 +2,7 @@
   "name": "react-on-rails",
   "version": "14.1.1",
   "description": "react-on-rails JavaScript for react_on_rails Ruby gem",
-  "main": "node_package/lib/ReactOnRails.js",
+  "main": "node_package/lib/ReactOnRails.full.js",
   "exports": {
     ".": {
       "node": "./node_package/lib/ReactOnRails.node.js",
@@ -14,6 +14,7 @@
     "doc": "docs"
   },
   "devDependencies": {
+    "@arethetypeswrong/cli": "^0.17.4",
     "@babel/core": "^7.20.12",
     "@babel/preset-env": "^7.20.2",
     "@tsconfig/node14": "^14.1.2",

script/convert

@@ -15,8 +15,9 @@ File.rename(old_config, new_config)
 
 gsub_file_content("../Gemfile.development_dependencies", 'gem "shakapacker", "8.0.0"', 'gem "shakapacker", "6.6.0"')
 
-# Knip doesn't work on the oldest supported Node version and isn't needed there anyway
+# The below packages don't work on the oldest supported Node version and aren't needed there anyway
 gsub_file_content("../package.json", /"knip": "[^"]*",/, "")
+gsub_file_content("../package.json", %r{"@arethetypeswrong/cli": "[^"]*",}, "")
 
 gsub_file_content("../spec/dummy/package.json", '"shakapacker": "8.0.0",', '"shakapacker": "6.6.0",')