exceptions seem to properly propagate now

Author: sharpjd

GPUPrefSwitcher.sln

@@ -151,7 +151,6 @@ Global
 		{76BFD458-C88C-4484-9578-DC1B75BB945C}.Debug|Any CPU.ActiveCfg = Debug
 		{76BFD458-C88C-4484-9578-DC1B75BB945C}.Debug|ARM64.ActiveCfg = Debug
 		{76BFD458-C88C-4484-9578-DC1B75BB945C}.Debug|x64.ActiveCfg = Debug
-		{76BFD458-C88C-4484-9578-DC1B75BB945C}.Debug|x64.Build.0 = Debug
 		{76BFD458-C88C-4484-9578-DC1B75BB945C}.Debug|x86.ActiveCfg = Debug
 		{76BFD458-C88C-4484-9578-DC1B75BB945C}.Release|Any CPU.ActiveCfg = Release
 		{76BFD458-C88C-4484-9578-DC1B75BB945C}.Release|ARM64.ActiveCfg = Release

GPUPrefSwitcher/AppLogger.cs

@@ -104,6 +104,7 @@ public static AppLogger Initialize (string logFolderPath_Error, string logFileNa
             //Might trigger StackOverflow if the functions inside this errors (log error -> error -> log error -> error ...)
             AppDomain.CurrentDomain.UnhandledException += (sender, e) => //Only handles uncaught ones (that terminate the app), which is what we want
             {
+                logger.Log("An unhandled error has occurred, check the Error Log");
                 logger.DumpStandardLogBufferToStandardLog().Wait();
                 logger.DumpStandardLogBufferToErrorLog().Wait(); //do this before the app terminates
                 logger.ErrorLog("<<<AN UNHANDLED ERROR HAS OCCURRED>>>");
@@ -114,6 +115,7 @@ public static AppLogger Initialize (string logFolderPath_Error, string logFileNa
             ///TODO this doesn't work?
             System.Threading.Tasks.TaskScheduler.UnobservedTaskException += (sender, e) => 
             {
+                logger.Log("An unobserved task exception has occurred, check the Error Log");
                 logger.DumpStandardLogBufferToStandardLog().Wait();
                 logger.DumpStandardLogBufferToErrorLog().Wait(); //do this before the app terminates
                 logger.ErrorLog("<<<AN UNOBSERVED TASK EXCEPTION HAS OCCURRED>>>");

GPUPrefSwitcher/Switcher.cs

@@ -41,7 +41,7 @@ public static class Switcher
         /// <summary>
         /// Call once upon service start. Initializes necessary components and starts the timer.
         /// </summary>
-        internal static void Start()
+        internal static void Start(CancellationToken cancellationToken)
         {
             appOptions = new AppOptions();
             Logger.inst.EnableRealtimeStandardLogWrites = appOptions.CurrentOptions.EnableRealtimeLogging;
@@ -70,7 +70,7 @@ internal static void Start()
 
             File.Delete(CRASHED_FILE_PATH);//"successful" initialization yippee
 
-            Task forever = BeginTimerForever();
+            Task forever = BeginTimerForever(cancellationToken);
 
             /*
             forever.ContinueWith(
@@ -119,15 +119,16 @@ internal static void Stop()
         /// <summary>
         /// There should be only one of this running at any time.
         /// </summary>
-        private static async Task BeginTimerForever()
+        private static Task BeginTimerForever(CancellationToken cancellationToken)
         {
             if (timerRunning) { throw new InvalidOperationException("This function cannot be called more than once"); }
             timerRunning = true;
-            while (true)
+            while (!cancellationToken.IsCancellationRequested)
             {
 
-                foreach(Task task in runningUpdateTasks)
+                for (int i = runningUpdateTasks.Count - 1; i >= 0; i--)
                 {
+                    Task task = runningUpdateTasks[i];
                     //TODO run a new task even if the previous one is going
                     if (task != null && task.IsFaulted)
                     {
@@ -145,8 +146,10 @@ private static async Task BeginTimerForever()
 
                 runningUpdateTasks.Add(RunUpdateLogic());
 
-                await Task.Delay(updateInterval); //move this to the beginning to make debugging easier
+                Task.Delay(updateInterval).Wait(); //move this to the beginning to make debugging easier
             }
+
+            return Task.CompletedTask;
         }
 
         private static async Task RunUpdateLogic()

GPUPrefSwitcher/SwitcherService.cs

@@ -19,11 +19,10 @@ public SwitcherService(ILogger<SwitcherService> logger)
 
         public Task StartAsync(CancellationToken cancellationToken)
         {
-
-            Switcher.Start();
-
             SystemEvents.SessionEnding += OnSessionEnd;
 
+            Switcher.Start(cancellationToken);
+
             return Task.CompletedTask;
         }