Skip to content

Commit 17f2f45

Browse files
AnnaAnna
Anna
authored and
Anna
committed
Fixes wait time bug
1 parent 6e25557 commit 17f2f45

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

bot.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def message_response(bot, ircmsg, actor, ircsock, channel, greeters):
170170

171171
# If someone tries to change the wait time...
172172
if ircmsg.find(bot.botnick + " --wait-time ") != -1:
173-
bot.wait_time = wait_time_change(actor, ircmsg, ircsock, channel, greeters) # call this to check and change it
173+
bot.wait_time = wait_time_change(actor, ircmsg, ircsock, channel, greeters, bot) # call this to check and change it
174174

175175
# If the server pings us then we've got to respond!
176176
if ircmsg.find("PING :") != -1:
@@ -206,17 +206,20 @@ def greeter_string(greeters):
206206
return greeterstring
207207

208208
# Changes the wait time from the channel.
209-
def wait_time_change(actor, ircmsg, ircsock, channel, channel_greeters):
209+
def wait_time_change(actor, ircmsg, ircsock, channel, channel_greeters, bot):
210210
for admin in channel_greeters:
211211
if actor == admin:
212212
finder = re.search(r'\d\d*', re.search(r'--wait-time \d\d*', ircmsg)
213213
.group())
214214
ircsock.send("PRIVMSG {0} :{1} the wait time is changing to {2} "
215215
"seconds.\n".format(channel, actor, finder.group()))
216-
return int(finder.group())
216+
new_wait_time = int(finder.group())
217+
return new_wait_time
217218
ircsock.send("PRIVMSG {0} :{1} you are not authorized to make that "
218219
"change. Please contact one of the channel greeters, like {2}, for "
219220
"assistance.\n".format(channel, actor, greeter_string(channel_greeters)))
221+
unchanged_wait_time = bot.wait_time
222+
return unchanged_wait_time
220223

221224
# Responds to server Pings.
222225
def pong(ircsock, ircmsg):

test_bot.py

+2
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,12 @@ def test_help(self):
187187
def test_wait_time_from_admin(self):
188188
botcode.message_response(self.bot,"{} --wait-time 40".format(self.bot.botnick),"shauna",ircsock=self.ircsock, channel=settings.channel, greeters=settings.channel_greeters) # Channel-greeters may also be changed. :(
189189
self.assertEqual(self.ircsock.sent_message(), "PRIVMSG {} :shauna the wait time is changing to 40 seconds.\n".format(settings.channel))
190+
self.assertEqual(self.bot.wait_time, 40)
190191

191192
def test_wait_time_from_non_admin(self):
192193
botcode.message_response(self.bot,"{} --wait-time 40".format(self.bot.botnick),"Impostor",ircsock=self.ircsock, channel=settings.channel, greeters=settings.channel_greeters) # Channel-greeters may also be changed. :(
193194
self.assertEqual(self.ircsock.sent_message(), "PRIVMSG {0} :Impostor you are not authorized to make that change. Please contact one of the channel greeters, like {1}, for assistance.\n".format(settings.channel,botcode.greeter_string(settings.channel_greeters)))
195+
self.assertEqual(self.bot.wait_time, settings.wait_time)
194196

195197
def test_pong(self):
196198
botcode.message_response(self.bot,"PING :","Shauna",ircsock=self.ircsock, channel=settings.channel, greeters=settings.channel_greeters) # Replace this with actual ping message

0 commit comments

Comments
 (0)