sshd: Close connection on failed handshake

shazow · shazow · commit 5949f9792f02 · 2019-04-17T16:57:30.000-04:00
Hopefully fixed #315
diff --git a/sshd/net.go b/sshd/net.go
@@ -59,6 +59,7 @@ func (l *SSHListener) Serve() {
 			term, err := l.handleConn(conn)
 			if err != nil {
 				logger.Printf("[%s] Failed to handshake: %s", conn.RemoteAddr(), err)
+				conn.Close() // Must be closed to avoid a leak
 				return
 			}
 			l.HandlerFunc(term)

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@ func (l *SSHListener) Serve() {`
`59`	`59`	`term, err := l.handleConn(conn)`
`60`	`60`	`if err != nil {`
`61`	`61`	`logger.Printf("[%s] Failed to handshake: %s", conn.RemoteAddr(), err)`
	`62`	`+ conn.Close() // Must be closed to avoid a leak`
`62`	`63`	`return`
`63`	`64`	`}`
`64`	`65`	`l.HandlerFunc(term)`