/uptime and /whois relative timestamps made more precise

Replaced go-humanize dependency with our own logic.

Fixes #259.

Author: shazow

Gopkg.lock

@@ -8,7 +8,6 @@ import (
 	"sync"
 	"time"
 
-	"github.com/dustin/go-humanize"
 	"github.com/shazow/rateio"
 	"github.com/shazow/ssh-chat/chat"
 	"github.com/shazow/ssh-chat/chat/message"
@@ -382,7 +381,7 @@ func (h *Host) InitCommands(c *chat.Commands) {
 	c.Add(chat.Command{
 		Prefix: "/uptime",
 		Handler: func(room *chat.Room, msg message.CommandMsg) error {
-			room.Send(message.NewSystemMsg(humanize.Time(timeStarted), msg.From()))
+			room.Send(message.NewSystemMsg(humanSince(time.Since(timeStarted)), msg.From()))
 			return nil
 		},
 	})

host.go

@@ -0,0 +1,19 @@
+package sshchat
+
+import (
+	"fmt"
+	"time"
+)
+
+// humanSince returns a human-friendly relative time string
+func humanSince(d time.Duration) string {
+	switch {
+	case d < time.Minute*2:
+		return fmt.Sprintf("%0.f seconds", d.Seconds())
+	case d < time.Hour*2:
+		return fmt.Sprintf("%0.f minutes", d.Minutes())
+	case d < time.Hour*48:
+		return fmt.Sprintf("%0.f hours", d.Hours())
+	}
+	return fmt.Sprintf("%0.f days", d.Hours()/24)
+}

humantime.go

@@ -0,0 +1,40 @@
+package sshchat
+
+import (
+	"testing"
+	"time"
+)
+
+func TestHumanSince(t *testing.T) {
+	tests := []struct {
+		input    time.Duration
+		expected string
+	}{
+		{
+			time.Second * 42,
+			"42 seconds",
+		},
+		{
+			time.Second * 60 * 5,
+			"5 minutes",
+		},
+		{
+			time.Hour * 3,
+			"3 hours",
+		},
+		{
+			time.Hour * 49,
+			"2 days",
+		},
+		{
+			time.Hour * 24 * 900,
+			"900 days",
+		},
+	}
+
+	for _, test := range tests {
+		if actual, expected := humanSince(test.input), test.expected; actual != expected {
+			t.Errorf("Got: %q; Expected: %q", actual, expected)
+		}
+	}
+}

humantime_test.go

@@ -4,7 +4,6 @@ import (
 	"net"
 	"time"
 
-	"github.com/dustin/go-humanize"
 	"github.com/shazow/ssh-chat/chat"
 	"github.com/shazow/ssh-chat/chat/message"
 	"github.com/shazow/ssh-chat/sshd"
@@ -51,7 +50,7 @@ func (i Identity) Whois() string {
 	return "name: " + i.Name() + message.Newline +
 		" > fingerprint: " + fingerprint + message.Newline +
 		" > client: " + chat.SanitizeData(string(i.ClientVersion())) + message.Newline +
-		" > joined: " + humanize.Time(i.created)
+		" > joined: " + humanSince(time.Since(i.created)) + " ago"
 }
 
 // WhoisAdmin returns a whois description for admin users.
@@ -65,5 +64,5 @@ func (i Identity) WhoisAdmin() string {
 		" > ip: " + ip + message.Newline +
 		" > fingerprint: " + fingerprint + message.Newline +
 		" > client: " + chat.SanitizeData(string(i.ClientVersion())) + message.Newline +
-		" > joined: " + humanize.Time(i.created)
+		" > joined: " + humanSince(time.Since(i.created)) + " ago"
 }