From 68283f3654e4cde611d91b86775406fd75209633 Mon Sep 17 00:00:00 2001 From: Marco Rubin <20150305+Rubo3@users.noreply.github.com> Date: Wed, 9 Feb 2022 12:52:41 +0000 Subject: [PATCH] Simplify verify_mkvmerge `shutil.which` already does the job. --- pymkv/Verifications.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pymkv/Verifications.py b/pymkv/Verifications.py index ad74270..39d5926 100644 --- a/pymkv/Verifications.py +++ b/pymkv/Verifications.py @@ -7,6 +7,7 @@ import os from os.path import expanduser, isfile from re import match +from shutil import which import subprocess as sp @@ -16,13 +17,7 @@ def verify_mkvmerge(mkvmerge_path='mkvmerge'): mkvmerge_path (str): Alternate path to mkvmerge if it is not already in the $PATH variable. """ - try: - output = sp.check_output([mkvmerge_path, '-V']).decode() - except (sp.CalledProcessError, FileNotFoundError): - return False - if match('mkvmerge.*', output): - return True - return False + return which(mkvmerge_path) is not None def verify_matroska(file_path, mkvmerge_path='mkvmerge'):