Skip to content

Commit 3d393da

Browse files
committed
Merge branch 'feature/fix-update-macos-deployment-target'
2 parents 13f8da9 + ea5267d commit 3d393da

File tree

4 files changed

+34
-6
lines changed

4 files changed

+34
-6
lines changed

CHANGES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@
1212
VERSION ファイルを上げただけの場合は変更履歴記録は不要。
1313
パッチやビルドの変更のみ記録すること。
1414

15+
## m120.6099.1.2
16+
17+
- [ADD] DEPS ファイルを追加して、依存するバージョンを明示する
18+
- @melpon
19+
1520
## m119.6045.2.1
1621

1722
- [ADD] H.265 パッチを追加する WebRTC 119.6045.2.0 / WebKit f92a593e ベース

DEPS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
MACOS_DEPLOYMENT_TARGET=12

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
WEBRTC_BUILD_VERSION=120.6099.1.1
1+
WEBRTC_BUILD_VERSION=120.6099.1.2
22
WEBRTC_VERSION=120.6099.1
33
WEBRTC_READABLE_VERSION=M120.6099@{#1}
44
WEBRTC_COMMIT=b0cc68e61205fd11a7256a6e85307ec17ad95790

run.py

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,9 @@ def git_get_url_and_revision(dir):
330330
'webrtc_commit',
331331
'webrtc_build_version',
332332
])
333+
DepsInfo = collections.namedtuple('DepsInfo', [
334+
'macos_deployment_target',
335+
])
333336

334337

335338
def archive_objects(ar, dir, output):
@@ -468,7 +471,7 @@ def get_webrtc_version_info(version_info: VersionInfo):
468471

469472

470473
def build_webrtc_ios(
471-
source_dir, build_dir, version_info: VersionInfo, extra_gn_args,
474+
source_dir, build_dir, version_info: VersionInfo, deps_info: DepsInfo, extra_gn_args,
472475
webrtc_source_dir=None, webrtc_build_dir=None,
473476
debug=False,
474477
gen=False, gen_force=False,
@@ -533,7 +536,8 @@ def build_webrtc_ios(
533536
with cd(os.path.join(webrtc_src_dir, 'tools_webrtc', 'ios')):
534537
ios_deployment_target = cmdcap(
535538
['python3', '-c',
536-
f'from build_ios_libs import IOS_MINIMUM_DEPLOYMENT_TARGET; print(IOS_MINIMUM_DEPLOYMENT_TARGET["{device}"])'])
539+
'from build_ios_libs import IOS_MINIMUM_DEPLOYMENT_TARGET;'
540+
f'print(IOS_MINIMUM_DEPLOYMENT_TARGET["{device}"])'])
537541

538542
if not os.path.exists(os.path.join(work_dir, 'args.gn')) or gen or overlap_build_dir:
539543
gn_args = [
@@ -564,7 +568,7 @@ def build_webrtc_ios(
564568

565569

566570
def build_webrtc_android(
567-
source_dir, build_dir, version_info: VersionInfo, extra_gn_args,
571+
source_dir, build_dir, version_info: VersionInfo, deps_info: DepsInfo, extra_gn_args,
568572
webrtc_source_dir=None, webrtc_build_dir=None,
569573
debug=False,
570574
gen=False, gen_force=False,
@@ -628,7 +632,7 @@ def build_webrtc_android(
628632

629633

630634
def build_webrtc(
631-
source_dir, build_dir, target: str, version_info: VersionInfo, extra_gn_args,
635+
source_dir, build_dir, target: str, version_info: VersionInfo, deps_info: DepsInfo, extra_gn_args,
632636
webrtc_source_dir=None, webrtc_build_dir=None,
633637
debug=False,
634638
gen=False, gen_force=False,
@@ -660,7 +664,7 @@ def build_webrtc(
660664
gn_args += [
661665
'target_os="mac"',
662666
'target_cpu="arm64"',
663-
'mac_deployment_target="10.11"',
667+
f'mac_deployment_target="{deps_info.macos_deployment_target}"',
664668
'enable_stripping=true',
665669
'enable_dsyms=true',
666670
'rtc_libvpx_build_vp9=true',
@@ -784,6 +788,17 @@ def generate_version_info(webrtc_src_dir, webrtc_package_dir):
784788
f.writelines(map(lambda x: (x + '\n').encode('utf-8'), lines))
785789

786790

791+
def generate_deps_info(webrtc_src_dir, webrtc_package_dir):
792+
shutil.copyfile('DEPS', os.path.join(webrtc_package_dir, 'DEPS'))
793+
with cd(os.path.join(webrtc_src_dir, 'tools_webrtc', 'ios')):
794+
ios_deployment_target = cmdcap(
795+
['python3', '-c',
796+
'from build_ios_libs import IOS_MINIMUM_DEPLOYMENT_TARGET;'
797+
'print(IOS_MINIMUM_DEPLOYMENT_TARGET["device"])'])
798+
with open(os.path.join(webrtc_package_dir, 'DEPS'), 'ab') as f:
799+
f.write(f'IOS_DEPLOYMENT_TARGET={ios_deployment_target}\n'.encode('utf-8'))
800+
801+
787802
def package_webrtc(source_dir, build_dir, package_dir, target,
788803
webrtc_source_dir=None, webrtc_build_dir=None, webrtc_package_dir=None,
789804
overlap_ios_build_dir=False):
@@ -832,6 +847,9 @@ def package_webrtc(source_dir, build_dir, package_dir, target,
832847
# バージョン情報
833848
generate_version_info(webrtc_src_dir, webrtc_package_dir)
834849

850+
# 依存情報
851+
generate_deps_info(webrtc_src_dir, webrtc_package_dir)
852+
835853
# ライブラリ
836854
if target in ['windows_x86_64', 'windows_arm64']:
837855
files = [
@@ -1051,6 +1069,9 @@ def main():
10511069
webrtc_version=version_file['WEBRTC_VERSION'],
10521070
webrtc_commit=version_file['WEBRTC_COMMIT'],
10531071
webrtc_build_version=version_file['WEBRTC_BUILD_VERSION'])
1072+
deps_file = read_version_file('DEPS')
1073+
deps_info = DepsInfo(
1074+
macos_deployment_target=deps_file['MACOS_DEPLOYMENT_TARGET'])
10541075

10551076
if args.op == 'build':
10561077
mkdir_p(source_dir)
@@ -1076,6 +1097,7 @@ def main():
10761097
'source_dir': source_dir,
10771098
'build_dir': build_dir,
10781099
'version_info': version_info,
1100+
'deps_info': deps_info,
10791101
'extra_gn_args': args.webrtc_extra_gn_args,
10801102
'webrtc_source_dir': webrtc_source_dir,
10811103
'webrtc_build_dir': webrtc_build_dir,

0 commit comments

Comments
 (0)