Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking grammar when upgrading to 1.24.0 #924

Open
3 of 5 tasks
julio4 opened this issue Feb 9, 2025 · 1 comment
Open
3 of 5 tasks

Breaking grammar when upgrading to 1.24.0 #924

julio4 opened this issue Feb 9, 2025 · 1 comment

Comments

@julio4
Copy link

julio4 commented Feb 9, 2025

Validations

Describe the bug

Without any changes in the grammar, it seems upgrading from 1.23 to ^1.24 cause unexpected breaking changes.
In my case it breaks the cairo highlighting.

It can be easily reproduced with tm-grammars previews: https://deploy-preview-100--textmate-grammars-themes.netlify.app/?theme=github-dark&grammar=cairo (from shikijs/textmate-grammars-themes#100) (shiki 1.20.0, but it works in 1.23.1 as well)

Compared to the current version:

Image

Reproduction

textmate grammars preview

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@slevithan
Copy link
Collaborator

Note: This is affecting both the Oniguruma and JavaScript engine.

Without any changes in the grammar, it seems upgrading from 1.23 to ^1.24 cause unexpected breaking changes. In my case it breaks the cairo highlighting.

But the Cairo grammar did change significantly (see shikijs/textmate-grammars-themes@71926b1), and based on the dates, it looks like this update shipped in Shiki 1.24.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants