Blah

Author: Shreyas Balakrishna

lib/cpp_dependency_graph/directory_parser.rb

@@ -0,0 +1,6 @@
+module DirectoryParser
+  def glob_files(path, extensions)
+    path = File.join(path, File::SEPARATOR) + '*' + extensions
+    Dir.glob(path).select { |entry| File.file?(entry) }.compact
+  end
+end

lib/cpp_dependency_graph/include_component_dependency_graph.rb

@@ -12,8 +12,7 @@ def initialize(project)
 
   def all_links
     components = @project.source_components
-    all_source_files = components.values.flat_map(&:source_files)
-    all_source_files.map do |file|
+    @project.source_files.map do |file|
       links = file.includes.map { |inc| Link.new(file.basename, inc, false) }
       [file.basename, links]
     end.to_h

lib/cpp_dependency_graph/include_file_dependency_graph.rb

@@ -10,22 +10,15 @@ def initialize(project)
     @project = project
   end
 
-  def all_links
-    # TODO: Implement
-    {}
-  end
-
   def all_cyclic_links
     # TODO: Implement
   end
 
   def links(file_name)
-    components = @project.source_components
-    all_source_files = components.values.flat_map(&:source_files)
-    files = all_source_files.select do |file|
+    files = @project.source_files.select do |_, file|
       file.includes.include?(file_name)
     end
-    files.map do |file|
+    files.map do |_, file|
       links = [Link.new(file.basename, file_name, false)]
       [file.basename, links]
     end.to_h

lib/cpp_dependency_graph/project.rb

@@ -21,6 +21,10 @@ def source_component(name)
     source_components[name]
   end
 
+  def source_files
+    @source_files ||= build_source_files
+  end
+
   def dependencies(component)
     # TODO: This is repeating the same work twice! component_for_include is called when calling external_includes
     external_includes(component).map { |include| @include_resolver.component_for_include(include) }.reject(&:empty?).uniq
@@ -32,6 +36,14 @@ def external_includes(component)
 
   private
 
+  def build_source_files
+    # TODO: Breaking Demeter's law here
+    files = source_components.values.flat_map(&:source_files)
+    files.map do |file|
+      [file.path, file]
+    end.to_h
+  end
+
   def build_source_components
     # TODO: Dealing with source components with same dir name?
     dirs = fetch_all_dirs(@path)

lib/cpp_dependency_graph/source_component.rb

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
 
 require_relative 'config'
+require_relative 'directory_parser'
 require_relative 'source_file'
 
 # Abstracts a source directory containing source files
 class SourceComponent
   include Config
+  include DirectoryParser
 
   attr_reader :path
 
@@ -32,7 +34,6 @@ def loc
   private
 
   def parse_source_files(extensions)
-    path = File.join(@path, File::SEPARATOR) + '*' + extensions
-    Dir.glob(path).map { |e| SourceFile.new(e) if File.file?(e) }.compact
+    glob_files(@path, extensions).map { |e| SourceFile.new(e) }.compact
   end
 end

spec/test/project_spec.rb

@@ -14,10 +14,22 @@
     expect(component.source_files.size).to eq(0)
   end
 
+  it 'returns null component if no such component exists' do
+    component = Project.new('spec/test/example_project').source_component('Unknown')
+    expect(component.name).to eq('NULL')
+    expect(component.source_files.size).to eq(0)
+  end
+
   it 'returns dependencies of component' do
     project = Project.new('spec/test/example_project')
     component = project.source_component('Engine')
     dependencies = project.dependencies(component)
     expect(dependencies).to include('Framework', 'UI', 'DataAccess')
   end
+
+  it 'all source files of project' do
+    project = Project.new('spec/test/example_project')
+    source_files = project.source_files.values.map(&:basename).sort
+    expect(source_files).to eq(["DA.h", "Display.cpp", "Display.h", "Engine.cpp", "Engine.h", "Engine.h", "OldEngine.h", "System.cpp", "System.h", "framework.h", "main.cpp"])
+  end
 end