Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

アスペクト比はCSSでやる #17

Open
shun91 opened this issue Dec 10, 2021 · 4 comments
Open

アスペクト比はCSSでやる #17

shun91 opened this issue Dec 10, 2021 · 4 comments

Comments

@shun91
Copy link
Owner

shun91 commented Dec 10, 2021

https://github.com/shun91/web-speed-hackathon-2021/blob/main/client/src/components/foundation/AspectRatioBox/AspectRatioBox.jsx#L25
@shun91
Copy link
Owner Author

shun91 commented Dec 10, 2021

image

image

@shun91 shun91 mentioned this issue Dec 10, 2021
Closed
shun91 added a commit that referenced this issue Dec 11, 2021
@shun91
⚡️ 不要と思われるsetTimeoutを削除 ( #17 )
297050d
@shun91
Copy link
Owner Author

shun91 commented Dec 11, 2021 •
edited
Loading

該当部分はアスペクト比の計算ロジックっぽいけど、これってCSSだけでうまいことできなかったっけ？

@shun91
Copy link
Owner Author

shun91 commented Dec 11, 2021

これでいけそう

CSS aspect-ratioプロパティの使い方、レスポンシブやレイアウトシフトで大活躍 | コリス
https://coliss.com/articles/build-websites/operation/css/how-to-use-aspect-ratio-css-property.html

shun91 added a commit that referenced this issue Dec 11, 2021
@shun91
⚡️ setImmediateにしてみる ( #17 )
738a833 
setTimeout消すだけだとスコアが悪くなったので試す
@shun91
Copy link
Owner Author

shun91 commented Dec 11, 2021 •
edited
Loading

誤差かもしれないけどsetImmediateの方が少しスコアがよかった

ただ、本来的には #17 (comment) の対応をしたほうが良さそう

@shun91 shun91 changed the title setTimeoutが不要かも？ アスペクト比はCSSでやる Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shun91