optimize price event triggering

Author: keithsue

x/dlc/keeper/event.go

@@ -1,6 +1,8 @@
 package keeper
 
 import (
+	"fmt"
+
 	sdkmath "cosmossdk.io/math"
 	storetypes "cosmossdk.io/store/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -89,14 +91,22 @@ func (k Keeper) SetEvent(ctx sdk.Context, event *types.DLCPriceEvent) {
 	store.Set(types.EventByPriceKey(event.TriggerPrice), sdk.Uint64ToBigEndian(event.Id))
 }
 
-// TriggerEvent sets the given event to triggered
-func (k Keeper) TriggerEvent(ctx sdk.Context, event *types.DLCPriceEvent) {
-	store := ctx.KVStore(k.storeKey)
-
+// TriggerEvent triggers the given event
+func (k Keeper) TriggerEvent(ctx sdk.Context, id uint64) {
+	event := k.GetEvent(ctx, id)
 	event.HasTriggered = true
 
-	bz := k.cdc.MustMarshal(event)
-	store.Set(types.EventKey(event.Id), bz)
+	k.SetEvent(ctx, event)
+
+	ctx.EventManager().EmitEvent(
+		sdk.NewEvent(
+			types.EventTypeTriggerEvent,
+			sdk.NewAttribute(types.AttributeKeyEventId, fmt.Sprintf("%d", id)),
+			sdk.NewAttribute(types.AttributeKeyPubKey, event.Pubkey),
+			sdk.NewAttribute(types.AttributeKeyNonce, event.Nonce),
+			sdk.NewAttribute(types.AttributeKeyPrice, event.TriggerPrice.String()),
+		),
+	)
 }
 
 // GetAllEvents gets all events

x/dlc/types/events.go

@@ -4,9 +4,15 @@ package types
 const (
 	EventTypeCreateOracle = "create_oracle"
 	EventTypeCreateAgency = "create_agency"
+	EventTypeTriggerEvent = "trigger_event"
 
 	AttributeKeyId             = "id"
 	AttributeKeyParticipants   = "participants"
 	AttributeKeyThreshold      = "threshold"
 	AttributeKeyExpirationTime = "expiration_time"
+
+	AttributeKeyEventId = "event_id"
+	AttributeKeyPubKey  = "pub_key"
+	AttributeKeyNonce   = "nonce"
+	AttributeKeyPrice   = "price"
 )

x/lending/module/abci.go

@@ -59,18 +59,8 @@ func handleLoans(ctx sdk.Context, k keeper.Keeper) {
 			}
 			k.AuctionKeeper().CreateAuction(ctx, auction)
 
-			dlcEvent := k.DLCKeeper().GetEvent(ctx, loan.EventId)
-
-			// emit event
-			ctx.EventManager().EmitEvent(
-				sdk.NewEvent(
-					types.EventTypeLiquidate,
-					sdk.NewAttribute(types.AttributeKeyLoanId, loan.VaultAddress),
-					sdk.NewAttribute(types.AttributeKeyEventPubKey, dlcEvent.Pubkey),
-					sdk.NewAttribute(types.AttributeKeyEventNonce, dlcEvent.Nonce),
-					sdk.NewAttribute(types.AttributeKeyEventPrice, liquidationPrice.String()),
-				),
-			)
+			// trigger price event
+			k.DLCKeeper().TriggerEvent(ctx, loan.EventId)
 		}
 	}
 }

x/lending/types/expected_keepers.go

@@ -52,6 +52,7 @@ type AuctionKeeper interface {
 // DLCKeeper defines the expected DLC keeper interface
 type DLCKeeper interface {
 	GetEvent(ctx sdk.Context, id uint64) *dlctypes.DLCPriceEvent
+	TriggerEvent(ctx sdk.Context, id uint64)
 }
 
 // BtcBridgeKeeper defines the expected BtcBridge keeper interface