add duplicate check for dkg participants

keithsue · keithsue · commit afa021e32696 · 2024-12-31T10:55:02.000+08:00
diff --git a/x/btcbridge/types/msg_initiate_dkg.go b/x/btcbridge/types/msg_initiate_dkg.go
@@ -18,6 +18,8 @@ func (m *MsgInitiateDKG) ValidateBasic() error {
 		return ErrInvalidDKGParams
 	}
 
+	participants := make(map[string]bool)
+
 	for _, p := range m.Participants {
 		if len(p.Moniker) > stakingtypes.MaxMonikerLength {
 			return ErrInvalidDKGParams
@@ -30,6 +32,12 @@ func (m *MsgInitiateDKG) ValidateBasic() error {
 		if _, err := sdk.ConsAddressFromHex(p.ConsensusAddress); err != nil {
 			return errorsmod.Wrap(err, "invalid consensus address")
 		}
+
+		if participants[p.ConsensusAddress] {
+			return errorsmod.Wrap(ErrInvalidDKGParams, "duplicate participant")
+		}
+
+		participants[p.ConsensusAddress] = true
 	}
 
 	if len(m.VaultTypes) == 0 {

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,8 @@ func (m *MsgInitiateDKG) ValidateBasic() error {`
`18`	`18`	`return ErrInvalidDKGParams`
`19`	`19`	`}`
`20`	`20`
	`21`	`+ participants := make(map[string]bool)`
	`22`	`+`
`21`	`23`	`for _, p := range m.Participants {`
`22`	`24`	`if len(p.Moniker) > stakingtypes.MaxMonikerLength {`
`23`	`25`	`return ErrInvalidDKGParams`
`@@ -30,6 +32,12 @@ func (m *MsgInitiateDKG) ValidateBasic() error {`
`30`	`32`	`if _, err := sdk.ConsAddressFromHex(p.ConsensusAddress); err != nil {`
`31`	`33`	`return errorsmod.Wrap(err, "invalid consensus address")`
`32`	`34`	`}`
	`35`	`+`
	`36`	`+ if participants[p.ConsensusAddress] {`
	`37`	`+ return errorsmod.Wrap(ErrInvalidDKGParams, "duplicate participant")`
	`38`	`+ }`
	`39`	`+`
	`40`	`+ participants[p.ConsensusAddress] = true`
`33`	`41`	`}`
`34`	`42`
`35`	`43`	`if len(m.VaultTypes) == 0 {`