-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoupdate fails on some networks #7159
Comments
What can you say about your network? Is it some sort of organization that has controls on how the connection is used? Is it an unstable connection that has frequent dropped packets or packet delays? It's possible that You have a lot of these in your log:
One of these (a success!):
And one of these as well, a different error, this time a timeout:
|
It's a home network connection that runs off of a 5G uplink. The connection is very stable; typical network performance is
Various network speed tests consistently show 0% packet loss. I've not observed any network filtering or other unusual behaviour from the ISP. The things that make suspect it's not (just) the ISP are: (1) the download is fine using
I've dumped the stderr stream from
I'm afraid this is misleading! That successful update was actually on a separate network connection (phone tethering) when trying to establish what the issue was. |
It certainly is interesting, the difference between your home network and tethering to your phone. You might try one of these more refined tests; they might be able to tell you if it's something related to router or even ISP hardware: |
The results from the Cloudflare test are as follows - I'm not seeing anything that suggests a network issue, and yet have just retried the autoupdate and still see the same issue.
Just for the avoidance of doubt, the two use different 5G networks so it does not completely rule out an ISP issue but certainly I don't see any obvious evidence of one. |
One big difference between the success and the failure is how long it takes to do the download: For the successful case, it took 14 seconds:
In the 'server aborted' failure case above, it took ~45 seconds:
And in the timeout case, it took almost two minutes for our 60s timeout to hit:
Lastly, I see that your successful curl test took 28 seconds. There's definitely something different about how the connection is made by Desktop - I don't think it's http/2 like curl does. You might try a lower-level network inspection tool (WireShark or similar) to watch what happens when Desktop interacts with the auto-update, since it reliably reproduces for you, but doesn't for any of us! |
Using a supported version?
Overall summary
On my home network connection, Signal desktop's autoupdate reliably fails and gives the "Cannot Update" error message in the sidebar. Looking at the debug logs, this is because during the download of the full update from
updates2.signal.org
, the connection is interrupted.If I tether to my phone, the autoupdate works correctly. Similarly, if I run
curl -k https://updates2.signal.org/desktop/signal-desktop-mac-arm64-7.40.1.zip --output signaltest1.zip
, the download completes successfully (even if--limit-rate
is set very low). So the issue is not just my network connection, but the combination of the Signal desktop app and my network connection - changing either means the download (and thus the autoupdate) works successfully.The network connection is unfiltered and I have checked that my DNS providers can correctly resolve
updates2.signal.org
domain. I am happy to run additional diagnostics to work out what is causing this issue but the above are the obvious tests and I am not sure what else would be helpful.Steps to reproduce
Expected result
Signal correctly autoupdates.
Actual result
See above. The error message is:
Screenshots
Signal version
7.40.1
Operating system
macOS 15.1.1 (Sequoia)
Version of Signal on your phone
No response
Link to debug log
https://debuglogs.org/desktop/7.40.1/ff9bfc4b9fc7238743dab59968a6a7ec429890ea18209be7d95065254d24e99d.gz
The text was updated successfully, but these errors were encountered: