Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Name Field Vanishes on iPad #5837

Open
3 tasks done
privacytime101 opened this issue Jul 15, 2024 · 5 comments
Open
3 tasks done

Chat Name Field Vanishes on iPad #5837

privacytime101 opened this issue Jul 15, 2024 · 5 comments

Comments

@privacytime101
Copy link

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

On some stale app launches (opening the app after a previous fresh launch), the name for the active chat window is missing at the top. Attached a screenshot of what this looks like. Note that I have not experienced this on iPhone/iOS.

Steps to reproduce

  • Restart iPad and open Signal, open a chat, then leave the app without force exiting.
  • A while later, reopen the app. If Signal didn’t close in the background, you might see the chat with a missing chat name.

Actual result: Describe here what happens after you run the steps above (i.e. the buggy behaviour)

On some stale launches, the chat name is missing. This does not happen every time. A workaround to get it displayed again is to switch to another chat, and then switch back to the previously open one.

Expected result: Describe here what should happen after you run the steps above (i.e. what would be the correct behaviour)

The chat name is displayed at the top as expected.

Screenshots

IMG_1231

Device info

Device: iPad (9th generation)

iOS version: 17.5.1

Signal version: 7.19.1 (208)

Link to debug log

Does not occur every time.

@BionicBison05
Copy link

This also happens on iOS when you simply change to landscape orientation and back to portrait.

Copy link

stale bot commented Dec 31, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 31, 2024
@MarlowBrown
Copy link
Contributor

Hey there!

I am a contributor to Signal iOS! I recently took on the challenge of figuring out what was making this bug happen, and I'm happy to have found out what it was. I have attached some videos for you to look over. The first one is of the bug happening. It happens as fast as you go home and then reopen a stale instance.

navbardisappearing.mov

This second one is with the patch implemented!

navbarbugsolved.mov

Here is the PR! :)

@stale stale bot removed the stale label Feb 4, 2025
@BionicBison05
Copy link

@MarlowBrown Thank you for working on this! Can you confirm whether this also fixes the issue I'm having where it disappears when rotating an iPhone to landscape and back to portrait?

@MarlowBrown
Copy link
Contributor

Yes @BionicBison05, this patch fixes the iPhone rotation bug :)

iPhoneRotation2.mov
iPhoneRotation.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants