Merge pull request #2551 from signalwire/v8_move

andywolk · web-flow · commit c303c98539a6 · 2024-07-30T19:10:16.000+03:00
[mod_v8] SayPhrase: Coverity 1546153 COPY_INSTEAD_OF_MOVE
diff --git a/src/mod/languages/mod_v8/src/fssession.cpp b/src/mod/languages/mod_v8/src/fssession.cpp
@@ -671,7 +671,7 @@ JS_SESSION_FUNCTION_IMPL(SayPhrase)
 		String::Utf8Value str(info[2]);
 		tmp = js_safe_str(*str);
 		if (!zstr(tmp.c_str())) {
-			phrase_lang = tmp;
+			phrase_lang = std::move(tmp);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -671,7 +671,7 @@ JS_SESSION_FUNCTION_IMPL(SayPhrase)`
`671`	`671`	`String::Utf8Value str(info[2]);`
`672`	`672`	`tmp = js_safe_str(*str);`
`673`	`673`	`if (!zstr(tmp.c_str())) {`
`674`		`- phrase_lang = tmp;`
	`674`	`+ phrase_lang = std::move(tmp);`
`675`	`675`	`}`
`676`	`676`	`}`
`677`	`677`