Allow configurable client signing algorithms #1938
Open
+460
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Cameron <[email protected]> Co-authored-by: Riccardo Schirone <[email protected]> Signed-off-by: Alex Cameron <[email protected]> Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
Signed-off-by: Riccardo Schirone <[email protected]>
ret2libc
force-pushed
the
configurable-crypto
branch
from
f046e70 to
5d81096
Compare
Signed-off-by: Riccardo Schirone <[email protected]>
ret2libc
force-pushed
the
configurable-crypto
branch
from
5d81096 to
277af89
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
- Coverage 57.93% 51.77% -6.16%
==========================================
Files 50 73 +23
Lines 3119 5680 +2561
==========================================
+ Hits 1807 2941 +1134
- Misses 1154 2463 +1309
- Partials 158 276 +118 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a --client-signing-algorithms flag to Fulcio to restrict what key/hash combinations are allowed.
Closes #1388
This is based on #1517, but I could not mark it as Ready because done by @tetsuo-cpp .
Release Note
Documentation