use display_name from id broker instead of concatenation

Author: jason-jackson

features/bootstrap/LoginContext.php

@@ -291,7 +291,6 @@ public function iShouldHaveTheCorrectAttributes()
         Assert::keyExists($userInfo, "sn");
         Assert::keyExists($userInfo, "givenName");
         Assert::keyExists($userInfo, "displayName");
-        Assert::Equals($userInfo["displayName"][0], trim($userInfo["sn"][0] + " " + $userInfo["givenName"][0]));
         Assert::keyExists($userInfo, "mail");
         Assert::keyExists($userInfo, "employeeNumber");
         Assert::keyExists($userInfo, "cn");

modules/silauth/src/Auth/Source/auth/IdBroker.php

@@ -94,7 +94,8 @@ public function getAuthenticatedUser(string $username, string $password): ?array
             $userInfo['method'],
             $userInfo['manager_email'] ?? null,
             $userInfo['profile_review'] ?? 'no',
-            $userInfo['member'] ?? []
+            $userInfo['member'] ?? [],
+            $userInfo['display_name'],
         );
     }
 }

modules/silauth/src/Auth/Source/saml/User.php

@@ -17,7 +17,8 @@ public static function convertToSamlFieldNames(
         array   $method,
         ?string $managerEmail,
         string  $profileReview,
-        array   $member
+        array   $member,
+        string  $displayName
     ): array {
 
         // eduPersonUniqueId (only alphanumeric allowed)
@@ -47,7 +48,7 @@ public static function convertToSamlFieldNames(
 
             'sn' => (array)$lastName,
             'givenName' => (array)$firstName,
-            'displayName' => (array)trim($firstName . " " . $lastName),
+            'displayName' => (array)$displayName,
             'mail' => (array)$email,
             'employeeNumber' => (array)$employeeId,
             'cn' => (array)$username,