Skip to content

Commit 59ffb02

Browse files
tkent-googleCommit Bot
authored and
Commit Bot
committed
Update "LayoutTests" / "layout test" in docs/*.md.
This CL renames the following md files: - layout_tests_linux -> web_tests_linux.md - how_to_extend_layout_test_framework.md -> how_to_extend_web_test_framework.md - testing/layout_test_baseline_fallback.md -> testing/web_test_baseline_fallback.md - testing/layout_test_expectations.md -> testing/web_test_expectations.md - testing/layout_tests.md -> testing/web_tests.md - testing/layout_tests_in_content_shell.md -> testing/web_tests_in_content_shell.md - testing/layout_tests_tips.md -> testing/web_tests_tips.md - testing/layout_tests_with_manual_fallback.md -> testing/web_tests_with_manual_fallback.md - testing/writing_layout_tests -> testing/writing_web_tests.md No-Try: true Change-Id: Ied34815c92e449888b20818540a5ed0a76107bd1 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1350559 Commit-Queue: Kent Tamura <[email protected]> Reviewed-by: Quinten Yearsley <[email protected]> Cr-Commit-Position: refs/heads/master@{#611024}
1 parent 762831a commit 59ffb02

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+281
-289
lines changed

Diff for: docs/README.md

+13-14
Original file line numberDiff line numberDiff line change
@@ -145,20 +145,19 @@ used when committed.
145145
work.
146146

147147
### Testing
148-
* [Running and Debugging Layout Tests](testing/layout_tests.md)
149-
* [Writing Layout Tests](testing/writing_layout_tests.md) - Layout Tests using
148+
* [Running and Debugging Web Tests](testing/web_tests.md)
149+
* [Writing Web Tests](testing/writing_web_tests.md) - Web Tests using
150150
`content_shell`
151-
* [Layout Test Expectations and Baselines](testing/layout_test_expectations.md) -
152-
Setting expected results of layout tests.
153-
* [Layout Tests Tips](testing/layout_tests_tips.md) - Best practices for Layout
154-
Tests
155-
* [Layout Tests with Manual Fallback](testing/layout_tests_with_manual_fallback.md) -
151+
* [Web Test Expectations and Baselines](testing/web_test_expectations.md) -
152+
Setting expected results of web tests.
153+
* [Web Tests Tips](testing/web_tests_tips.md) - Best practices for web tests
154+
* [Web Tests with Manual Fallback](testing/webt_tests_with_manual_fallback.md) -
156155
Writing tests that simulate manual interventions
157-
* [Extending the Layout Test Framework](how_to_extend_layout_test_framework.md)
158-
* [Fixing Layout Test Flakiness](testing/identifying_tests_that_depend_on_order.md) -
159-
Diagnosing and fixing layout test flakiness due to ordering dependencies.
160-
* [Running Layout Tests using `content_shell`](testing/layout_tests_in_content_shell.md) -
161-
Running layout tests by hand.
156+
* [Extending the Web Test Framework](how_to_extend_web_test_framework.md)
157+
* [Fixing Web Test Flakiness](testing/identifying_tests_that_depend_on_order.md) -
158+
Diagnosing and fixing web test flakiness due to ordering dependencies.
159+
* [Running Web Tests using `content_shell`](testing/web_tests_in_content_shell.md) -
160+
Running web tests by hand.
162161
* [Web Platform Tests](testing/web_platform_tests.md) - Shared tests across
163162
browser vendors
164163
* [Using Breakpad with `content_shell`](testing/using_breakpad_with_content_shell.md) -
@@ -217,8 +216,8 @@ used when committed.
217216
isolate browser components with different privileges.
218217
* [Zygote Process](linux_zygote.md) - How the Linux Zygote process, used to
219218
spawn new processes, works.
220-
* [Running Layout Tests on Linux](layout_tests_linux.md) - Linux-specific
221-
instructions for running layout tests.
219+
* [Running Web Tests on Linux](web_tests_linux.md) - Linux-specific
220+
instructions for running web tests.
222221
* [Linux Sysroot Images](linux_sysroot.md) - How builds use libraries on Linux
223222
* [Linux Hardware Video Decoding](linux_hw_video_decode.md) - Enabling
224223
hardware video decode codepaths on Linux

Diff for: docs/accessibility/tests.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ a new one.
2222

2323
Test files:
2424
```
25-
third_party/WebKit/LayoutTests/accessibility
25+
third_party/blink/web_tests/accessibility
2626
```
2727

2828
Source code to AccessibilityController and WebAXObjectProxy:
2929
```
3030
content/shell/test_runner
3131
```
3232

33-
To run all accessibility LayoutTests:
33+
To run all accessibility web tests:
3434
```
3535
autoninja -C out/release blink_tests
3636
third_party/blink/tools/run_web_tests.py --build-directory=out --target=release accessibility/
@@ -39,7 +39,7 @@ third_party/blink/tools/run_web_tests.py --build-directory=out --target=release
3939
To run just one test by itself without the script:
4040
```
4141
autoninja -C out/release blink_tests
42-
out/release/content_shell --run-web-tests third_party/WebKit/LayoutTests/accessibility/name-calc-inputs.html
42+
out/release/content_shell --run-web-tests third_party/blink/web_tests/accessibility/name-calc-inputs.html
4343
```
4444

4545
## DumpAccessibilityTree tests

Diff for: docs/android_test_instructions.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,9 @@ out/Release/bin/java_deobfuscate out/Release/apks/ChromePublicTest.apk.mapping <
284284
Any stacks produced by test runner output will already be deobfuscated.
285285

286286

287-
## Running Blink Layout Tests
287+
## Running Blink Web Tests
288288

289-
See [Layout Tests](testing/layout_tests.md).
289+
See [Web Tests](testing/web_tests.md).
290290

291291
## Running GPU tests
292292

Diff for: docs/atom.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ $ ./build.py --clang-completer --system-libclang
5454

5555
## JavaScript lint
5656

57-
Install JavaScript linter for Blink layout tests.
57+
Install JavaScript linter for Blink web tests.
5858

5959
```
6060
$ npm install -g eslint eslint-config-google

Diff for: docs/how_to_add_your_feature_flag.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ to see
2828
4. how to use it in blink
2929
[[1](https://chromium-review.googlesource.com/c/554510/8/third_party/blnk/renderere/core/workers/worker_thread.cc)]
3030

31-
Also, this patch added a virtual test for running layout tests with the flag.
31+
Also, this patch added a virtual test for running web tests with the flag.
3232
When you add a flag, you can consider to use that.
3333

3434
## Step 2: Adding the feature flag to the chrome://flags UI.

Diff for: docs/how_to_extend_layout_test_framework.md renamed to docs/how_to_extend_web_test_framework.md

+14-15
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# How to Extend the Layout Test Framework
1+
# How to Extend the Web Test Framework
22

3-
The Layout Test Framework that Blink uses is a regression testing tool that is
3+
The Web Test Framework that Blink uses is a regression testing tool that is
44
multi-platform and it has a large amount of tools that help test varying types
55
of regression, such as pixel diffs, text diffs, etc. The framework is mainly
66
used by Blink, however it was made to be extensible so that other projects can
@@ -12,29 +12,28 @@ to help people who want to actually the framework to test whatever they want.
1212
## Background
1313

1414
Before you can start actually extending the framework, you should be familiar
15-
with how to use it. See the
16-
[layout tests documentation](testing/layout_tests.md).
15+
with how to use it. See the [web tests documentation](testing/web_tests.md).
1716

1817
## How to Extend the Framework
1918

2019
There are two parts to actually extending framework to test a piece of software.
2120
The first part is extending certain files in:
2221
[/third_party/blink/tools/blinkpy/web_tests/](/third_party/blink/tools/blinkpy/web_tests/)
23-
The code in `blinkpy/web_tests` is the layout test framework itself
22+
The code in `blinkpy/web_tests` is the web test framework itself
2423

2524
The second part is creating a driver (program) to actually communicate the
26-
layout test framework. This part is significantly more tricky and dependent on
25+
web test framework. This part is significantly more tricky and dependent on
2726
what exactly exactly is being tested.
2827

2928
### Part 1
3029

3130
This part isn’t too difficult. There are basically two classes that need to be
3231
extended (ideally, just inherited from). These classes are:
3332

34-
* `Driver`. Located in `layout_tests/port/driver.py`. Each instance of this is
33+
* `Driver`. Located in `web_tests/port/driver.py`. Each instance of this is
3534
the class that will actually an instance of the program that produces the
3635
test data (program in Part 2).
37-
* `Port`. Located in `layout_tests/port/base.py`. This class is responsible
36+
* `Port`. Located in `web_tests/port/base.py`. This class is responsible
3837
creating drivers with the correct settings, giving access to certain OS
3938
functionality to access expected files, etc.
4039

@@ -129,15 +128,15 @@ Here are some of the functions that most likely need to be overridden.
129128
* `layout_tests_dir`
130129
* This tells the port where to look for all the and everything associated
131130
with them such as resources files.
132-
* By default it returns the absolute path to the layout tests directory.
131+
* By default it returns the absolute path to the web tests directory.
133132
* If you are planning on running something in the chromium src/ directory,
134133
there are helper functions to allow you to return a path relative to the
135134
base of the chromium src directory.
136135

137136
The rest of the functions can definitely be overridden for your projects
138137
specific needs, however these are the bare minimum needed to get it running.
139138
There are also functions you can override to make certain actions that aren’t on
140-
by default always take place. For example, the layout test framework always
139+
by default always take place. For example, the web test framework always
141140
checks for system dependencies unless you pass in a switch. If you want them
142141
disabled for your project, just override `check_sys_deps` to always return OK.
143142
This way you don’t need to pass in so many switches.
@@ -173,7 +172,7 @@ and has stdout, stdin, stderr.
173172
#### Goals
174173

175174
Your goal for this part of the project is to create a program (or extend a
176-
program) to interface with the layout test framework. The layout test framework
175+
program) to interface with the web test framework. The layout test framework
177176
will communicate with this program to tell it what to do and it will accept data
178177
from this program to perform the regression testing or create new base line
179178
files.
@@ -189,7 +188,7 @@ This is how your code should be laid out.
189188
the `run_test()` in the driver.
190189
1. Infinite Loop (!)
191190
* After initialization, your program needs to actually wait for input,
192-
then process that input to carry out the test. In the context of layout
191+
then process that input to carry out the test. In the context of web
193192
testing, the `content_shell` needs to wait for an html file to navigate
194193
to, render it, then convert that rendering to a PNG. It does this
195194
constantly, until a signal/message is sent to indicate that no more
@@ -228,12 +227,12 @@ That’s basically what the skeleton of your program should be.
228227
### Details
229228

230229
This is information about how to do some specific things, such as sending data
231-
to the layout test framework.
230+
to the web test framework.
232231

233232
* Content Blocks
234-
* The layout test framework accepts output from your program in blocks of
233+
* The web test framework accepts output from your program in blocks of
235234
data through stdout. Therefore, printing to stdout is really sending
236-
data to the layout test framework.
235+
data to the web test framework.
237236
* Structure of block
238237
* “Header: Data\n”
239238
* Header indicates what type of data will be sent through. A list

Diff for: docs/infra/cq_builders.md

+11-11
Original file line numberDiff line numberDiff line change
@@ -116,18 +116,18 @@ builder.
116116
* [linux-blink-gen-property-trees](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-blink-gen-property-trees) ([`cq.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:cq.cfg+linux-blink-gen-property-trees)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux-blink-gen-property-trees))
117117

118118
Path regular expressions:
119-
* [`//third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees)
120-
* [`//third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/.+`](https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/)
119+
* [`//third_party/blink/web_tests/FlagExpectations/enable-blink-gen-property-trees`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/FlagExpectations/enable-blink-gen-property-trees)
120+
* [`//third_party/blink/web_tests/flag-specific/enable-blink-gen-property-trees/.+`](https://cs.chromium.org/chromium/src/third_party/blink/web_tests/flag-specific/enable-blink-gen-property-trees/)
121121

122122
* [linux-blink-rel](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-blink-rel) ([`cq.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:cq.cfg+linux-blink-rel)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux-blink-rel))
123123

124124
Path regular expressions:
125125
* [`//cc/.+`](https://cs.chromium.org/chromium/src/cc/)
126-
* [`//third_party/WebKit/LayoutTests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees)`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/WebKit/LayoutTests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees))
127-
* [`//third_party/WebKit/LayoutTests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/.+`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/WebKit/LayoutTests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/)
128-
* [`//third_party/blink/renderer/core/layout/compositing/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/compositing/)
129126
* [`//third_party/blink/renderer/core/(svg|paint)/.+`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/renderer/core/(svg|paint)/)
127+
* [`//third_party/blink/renderer/core/layout/compositing/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/compositing/)
130128
* [`//third_party/blink/renderer/platform/graphics/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/)
129+
* [`//third_party/blink/web_tests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees)`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees))
130+
* [`//third_party/blink/web_tests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/.+`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/)
131131

132132
* [linux_chromium_dbg_ng](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_dbg_ng) ([`cq.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:cq.cfg+linux_chromium_dbg_ng)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_chromium_dbg_ng))
133133

@@ -137,27 +137,27 @@ builder.
137137
* [linux_layout_tests_layout_ng](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_layout_tests_layout_ng) ([`cq.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:cq.cfg+linux_layout_tests_layout_ng)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_layout_tests_layout_ng))
138138

139139
Path regular expressions:
140-
* [`//third_party/Webkit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/Webkit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG)
141-
* [`//third_party/Webkit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/.+`](https://cs.chromium.org/chromium/src/third_party/Webkit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/)
142-
* [`//third_party/blink/renderer/core/editing/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/editing/)
143140
* [`//third_party/blink/renderer/core/(layout|paint)/ng/.+`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/renderer/core/(layout|paint)/ng/)
141+
* [`//third_party/blink/renderer/core/editing/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/editing/)
144142
* [`//third_party/blink/renderer/platform/fonts/shaping/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/fonts/shaping/)
143+
* [`//third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG)
144+
* [`//third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/.+`](https://cs.chromium.org/chromium/src/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/)
145145

146146
* [linux_layout_tests_slimming_paint_v2](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_layout_tests_slimming_paint_v2) ([`cq.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:cq.cfg+linux_layout_tests_slimming_paint_v2)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_layout_tests_slimming_paint_v2))
147147

148148
Path regular expressions:
149-
* [`//third_party/WebKit/LayoutTests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees)`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/WebKit/LayoutTests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees))
150-
* [`//third_party/WebKit/LayoutTests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/.+`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/WebKit/LayoutTests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/)
151149
* [`//third_party/blink/renderer/core/layout/compositing/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/compositing/)
152150
* [`//third_party/blink/renderer/core/(svg|paint)/.+`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/renderer/core/(svg|paint)/)
153151
* [`//third_party/blink/renderer/platform/graphics/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/)
152+
* [`//third_party/blink/web_tests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees)`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/FlagExpectations/(enable-slimming-paint-v2|enable-blink-gen-property-trees))
153+
* [`//third_party/blink/web_tests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/.+`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/flag-specific/(enable-slimming-paint-v2|enable-blink-gen-property-trees)/)
154154

155155
* [linux_mojo](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_mojo) ([`cq.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:cq.cfg+linux_mojo)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_mojo))
156156

157157
Path regular expressions:
158158
* [`//services/network/.+`](https://cs.chromium.org/chromium/src/services/network/)
159159
* [`//testing/buildbot/filters/mojo\\.fyi\\.network_.*`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:testing/buildbot/filters/mojo\\.fyi\\.network_.*)
160-
* [`//third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService)
160+
* [`//third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService)
161161

162162
* [linux_optional_gpu_tests_rel](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_optional_gpu_tests_rel) ([`cq.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:cq.cfg+linux_optional_gpu_tests_rel)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_optional_gpu_tests_rel))
163163

Diff for: docs/linux_build_instructions.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ pulseaudio-libs-devel zlib.i686 httpd mod_ssl php php-cli python-psutil wdiff \
413413
xorg-x11-server-Xvfb'
414414
```
415415

416-
The fonts needed by Blink's LayoutTests can be obtained by following [these
416+
The fonts needed by Blink's web tests can be obtained by following [these
417417
instructions](https://gist.github.com/pwnall/32a3b11c2b10f6ae5c6a6de66c1e12ae).
418418
For the optional packages:
419419

0 commit comments

Comments
 (0)