Skip to content

Commit ad92aa3

Browse files
andybonsCommit bot
authored and
Commit bot
committed
[Docs] Another round of stylistic fixes.
TBR=nodir BUG=524256 Review URL: https://codereview.chromium.org/1324603002 Cr-Commit-Position: refs/heads/master@{#346335}
1 parent 22afb31 commit ad92aa3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+3915
-2360
lines changed

docs/OWNERS

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
2-
3-
1+
*

docs/gtk_vs_views_gtk.md

+35-24
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,38 @@
1-
# Benefits of ViewsGtk
1+
# Gtk vs ViewsGtk
22

3-
* Better code sharing. For example, don't have to duplicate tab layout or bookmark bar layout code.
4-
* Tab Strip
5-
* Drawing
6-
* All the animationy bits
7-
* Subtle click selection behavior (curved corners)
8-
* Drag behavior, including dropping of files onto the URL bar
9-
* Closing behavior
10-
* Bookmarks bar
11-
* drag & drop behavior, including menus
12-
* chevron?
13-
* Easier for folks to work on both platforms without knowing much about the underlying toolkits.
14-
* Don't have to implement ui features twice.
3+
## Benefits of ViewsGtk
154

5+
* Better code sharing. For example, don't have to duplicate tab layout or
6+
bookmark bar layout code.
7+
* Tab Strip
8+
* Drawing
9+
* All the animationy bits
10+
* Subtle click selection behavior (curved corners)
11+
* Drag behavior, including dropping of files onto the URL bar
12+
* Closing behavior
13+
* Bookmarks bar
14+
* drag & drop behavior, including menus
15+
* chevron?
16+
* Easier for folks to work on both platforms without knowing much about the
17+
underlying toolkits.
18+
* Don't have to implement ui features twice.
1619

17-
# Benefits of Gtk
18-
* Dialogs
19-
* Native feel layout
20-
* Font size changes (e.g., changing the system font size will apply to our dialogs)
21-
* Better RTL (e.g., http://crbug.com/2822 http://crbug.com/5729 http://crbug.com/6082 http://crbug.com/6103 http://crbug.com/6125 http://crbug.com/8686 http://crbug.com/8649 )
22-
* Being able to obey the user's system theme
23-
* Accessibility for buttons and dialogs (but not for tabstrip and bookmarks)
24-
* A better change at good remote X performance?
25-
* We still would currently need Pango / Cairo for text layout, so it will be more efficient to just draw that during the Gtk pipeline instead of with Skia.
26-
* Gtk widgets will automatically "feel and behave" like Linux. The behavior of our own Views system does not necessarily feel right on Linux.
27-
* People working on Windows features don't need to worry about breaking the Linux build.
20+
## Benefits of Gtk
21+
22+
* Dialogs
23+
* Native feel layout
24+
* Font size changes (e.g., changing the system font size will apply to our
25+
dialogs)
26+
* Better RTL (e.g., http://crbug.com/2822 http://crbug.com/5729
27+
http://crbug.com/6082 http://crbug.com/6103 http://crbug.com/6125
28+
http://crbug.com/8686 http://crbug.com/8649)
29+
* Being able to obey the user's system theme
30+
* Accessibility for buttons and dialogs (but not for tabstrip and bookmarks)
31+
* A better change at good remote X performance?
32+
* We still would currently need Pango / Cairo for text layout, so it will be
33+
more efficient to just draw that during the Gtk pipeline instead of with
34+
Skia.
35+
* Gtk widgets will automatically "feel and behave" like Linux. The behavior of
36+
our own Views system does not necessarily feel right on Linux.
37+
* People working on Windows features don't need to worry about breaking the
38+
Linux build.

docs/how_to_extend_layout_test_framework.md

+233-93
Large diffs are not rendered by default.

docs/include_what_you_use.md

-82
This file was deleted.

docs/installation_at_vmware.md

+19-16
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,24 @@
1-
#How to install Chromium OS on VMWare
1+
# How to install Chromium OS on VMWare
22

3-
# Download
3+
## Download
44

5-
1.[Download VMware player](http://www.vmware.com/products/player/)
6-
<br>2.<a href='http://gdgt.com/google/chrome-os/download/'>Create gtgt.com account and download Chrome image</a>
5+
1. [Download VMware player](http://www.vmware.com/products/player/)
6+
2. [Create a gtgt.com account and download Chrome image](http://gdgt.com/google/chrome-os/download/)
77

8-
<h1>Mounting</h1>
8+
## Mounting
99

10-
1. Create a New Virtual Machine<br>
11-
<br>2. Do not selecting any OP-sys (other-other-etc)<br>
12-
<br>3. Delete your newly created hardisc (lets say you named it as Chrome)<br>
13-
<br>4. Move downloaded harddisc to the same folder as othere VMware files for this Virtual Machine<br>
14-
<br>5. Rename your downloaded hardisc to newly created Virtual Machine original name (in my example it was Chrome)<br>
15-
<br>6. Boot the Chrome Virtual Machine (recommended to use NAT network configuration)<br>
16-
<br>
17-
<h1>Google results</h1>
10+
1. Create a New Virtual Machine
11+
1. Do not selecting any OP-sys (other-other-etc)
12+
1. Delete your newly created hardisc (lets say you named it as Chrome)
13+
1. Move downloaded harddisc to the same folder as othere VMware files for this
14+
Virtual Machine
15+
1. Rename your downloaded hardisc to newly created Virtual Machine original
16+
name (in my example it was Chrome)
17+
1. Boot the Chrome Virtual Machine (recommended to use NAT network
18+
configuration)
1819

19-
> <a href='http://discuss.gdgt.com/google/chrome-os/general/download-chrome-os-vmware-image/'>http://discuss.gdgt.com/google/chrome-os/general/download-chrome-os-vmware-image/</a>
20-
<br>> <a href='http://www.engadget.com/2009/11/20/google-chrome-os-available-as-free-vmware-download/'>http://www.engadget.com/2009/11/20/google-chrome-os-available-as-free-vmware-download/</a>
21-
<br>> <a href='http://blogs.zdnet.com/gadgetreviews/?p=9583'>http://blogs.zdnet.com/gadgetreviews/?p=9583</a>
20+
## Google results
21+
22+
* http://discuss.gdgt.com/google/chrome-os/general/download-chrome-os-vmware-image/
23+
* http://www.engadget.com/2009/11/20/google-chrome-os-available-as-free-vmware-download/
24+
* http://blogs.zdnet.com/gadgetreviews/?p=9583'>http://blogs.zdnet.com/gadgetreviews/?p=9583

docs/installazione_su_vmware.md

+20-15
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,25 @@
1-
#Come installare Chromium OS su VMWare
1+
# Come installare Chromium OS su VMWare
22

3-
# Download
3+
## Download
44

5-
1.[Scarica VMware player](http://www.vmware.com/products/player/)
6-
<br>2.<a href='http://gdgt.com/google/chrome-os/download/'>Crea un account su gtgt.com account e scarica l'immagine di Chrome</a>
5+
1. [Scarica VMware player](http://www.vmware.com/products/player/)
6+
2. [Crea un account su gtgt.com account e scarica l'immagine di Chrome](http://gdgt.com/google/chrome-os/download/)
77

8-
<h1>Montare l'Immagine</h1>
8+
## Montare l'Immagine
99

10-
1. Crea una nuova Virtual Machine<br>
11-
<br>2. Non selezionare nessun sistema operativo (other-other-ecc)<br>
12-
<br>3. Elimina l'hard disk virtuale appena creato (se hai nominato la virtual machine "Chrome", elimina il file "Chrome.vmdk" )<br>
13-
<br>4. Sposta l'immagine dell'Hard Disk scaricato nella stessa cartella dove vi sono gli altri files di VMware per questa virtual machine<br>
14-
<br>5. Rinomina l'immagine dell'Hard Disk scaricato con il nome della Virtual Machine creata (nel mio esempio è Chrome)<br>
15-
<br>6. Avvia la Virtual Machine (si consiglia di usare la configurazione di rete NAT)<br>
16-
<h1>Risultati di Google</h1>
10+
1. Crea una nuova Virtual Machine
11+
1. Non selezionare nessun sistema operativo (other-other-ecc)
12+
1. Elimina l'hard disk virtuale appena creato (se hai nominato la virtual
13+
machine "Chrome", elimina il 1i le "Chrome.vmdk" )
14+
1. Sposta l'immagine dell'Hard Disk scaricato nella stessa cartella dove vi
15+
sono gli altri files di 1M ware per questa virtual machine
16+
1. Rinomina l'immagine dell'Hard Disk scaricato con il nome della Virtual
17+
Machine creata (nel mio 1s empio è Chrome)
18+
1. Avvia la Virtual Machine (si consiglia di usare la configurazione di rete
19+
NAT)
1720

18-
> <a href='http://discuss.gdgt.com/google/chrome-os/general/download-chrome-os-vmware-image/'>http://discuss.gdgt.com/google/chrome-os/general/download-chrome-os-vmware-image/</a>
19-
<br>> <a href='http://www.engadget.com/2009/11/20/google-chrome-os-available-as-free-vmware-download/'>http://www.engadget.com/2009/11/20/google-chrome-os-available-as-free-vmware-download/</a>
20-
<br>> <a href='http://blogs.zdnet.com/gadgetreviews/?p=9583'>http://blogs.zdnet.com/gadgetreviews/?p=9583</a>
21+
## Risultati di Google
22+
23+
* http://discuss.gdgt.com/google/chrome-os/general/download-chrome-os-vmware-image/
24+
* http://www.engadget.com/2009/11/20/google-chrome-os-available-as-free-vmware-download/
25+
* http://blogs.zdnet.com/gadgetreviews/?p=9583'>http://blogs.zdnet.com/gadgetreviews/?p=9583

docs/ipc_fuzzer.md

+47-34
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,65 @@
1-
# Introduction
1+
# IPC Fuzzer
22

3-
A chromium IPC fuzzer is under development by aedla and tsepez. The fuzzer lives under `src/tools/ipc_fuzzer/` and is running on ClusterFuzz. A previous version of the fuzzer was a simple bitflipper, which caught around 10 bugs. A new version is doing smarter mutations and generational fuzzing. To do so, each `ParamTraits<Type>` needs a corresponding `FuzzTraits<Type>`. Feel free to contribute.
3+
A chromium IPC fuzzer is under development by aedla and tsepez. The fuzzer lives
4+
under `src/tools/ipc_fuzzer/` and is running on ClusterFuzz. A previous version
5+
of the fuzzer was a simple bitflipper, which caught around 10 bugs. A new
6+
version is doing smarter mutations and generational fuzzing. To do so, each
7+
`ParamTraits<Type>` needs a corresponding `FuzzTraits<Type>`. Feel free to
8+
contribute.
49

10+
[TOC]
511

6-
---
12+
## Working with the fuzzer
713

8-
# Working with the fuzzer
14+
### Build instructions
915

10-
## Build instructions
11-
* add `enable_ipc_fuzzer=1` to `GYP_DEFINES`
12-
* build `ipc_fuzzer_all` target
13-
* component builds are currently broken, sorry
14-
* Debug builds are broken; only Release mode works.
16+
* add `enable_ipc_fuzzer=1` to `GYP_DEFINES`
17+
* build `ipc_fuzzer_all` target
18+
* component builds are currently broken, sorry
19+
* Debug builds are broken; only Release mode works.
1520

16-
## Replaying ipcdumps
17-
* `tools/ipc_fuzzer/scripts/play_testcase.py path/to/testcase.ipcdump`
18-
* more help: `tools/ipc_fuzzer/scripts/play_testcase.py -h`
21+
### Replaying ipcdumps
1922

20-
## Listing messages in ipcdump
21-
* `out/`_Build_`/ipc_message_util --dump path/to/testcase.ipcdump`
23+
* `tools/ipc_fuzzer/scripts/play_testcase.py path/to/testcase.ipcdump`
24+
* more help: `tools/ipc_fuzzer/scripts/play_testcase.py -h`
2225

23-
## Updating fuzzers in ClusterFuzz
24-
* `tools/ipc_fuzzer/scripts/cf_package_builder.py`
25-
* upload `ipc_fuzzer_mut.zip` and `ipc_fuzzer_gen.zip` under build directory to ClusterFuzz
26+
### Listing messages in ipcdump
2627

27-
## Contributing FuzzTraits
28-
* add them to tools/ipc\_fuzzer/fuzzer/fuzzer.cc
29-
* thanks!
28+
* `out/<Build>/ipc_message_util --dump path/to/testcase.ipcdump`
3029

30+
### Updating fuzzers in ClusterFuzz
3131

32-
---
32+
* `tools/ipc_fuzzer/scripts/cf_package_builder.py`
33+
* upload `ipc_fuzzer_mut.zip` and `ipc_fuzzer_gen.zip` under build directory
34+
to ClusterFuzz
3335

34-
# Components
36+
### Contributing FuzzTraits
3537

36-
## ipcdump logger
37-
* add `enable_ipc_fuzzer=1` to `GYP_DEFINES`
38-
* build `chrome` and `ipc_message_dump` targets
39-
* run chrome with `--no-sandbox --ipc-dump-directory=/path/to/ipcdump/directory`
40-
* ipcdumps will be created in this directory for each renderer using the format _pid_.ipcdump
38+
* add them to `tools/ipc_fuzzer/fuzzer/fuzzer.cc`
39+
* thanks!
4140

42-
## ipcdump replay
43-
Lives under `ipc_fuzzer/replay`. The renderer is replaced with `ipc_fuzzer_replay` using `--renderer-cmd-prefix`. This is done automatically with the `ipc_fuzzer/play_testcase.py` convenience script.
41+
## Components
4442

45-
## ipcdump mutator / generator
46-
Lives under `ipc_fuzzer/fuzzer`. This is the code that runs on ClusterFuzz. It uses `FuzzTraits<Type>` to mutate ipcdumps or generate them out of thin air.
43+
### ipcdump logger
4744

45+
* add `enable_ipc_fuzzer=1` to `GYP_DEFINES`
46+
* build `chrome` and `ipc_message_dump` targets
47+
* run chrome with
48+
`--no-sandbox --ipc-dump-directory=/path/to/ipcdump/directory`
49+
* ipcdumps will be created in this directory for each renderer using the
50+
format `_pid_.ipcdump`
4851

49-
---
52+
### ipcdump replay
5053

51-
# Problems, questions, suggestions
52-
Send them to [email protected].
54+
Lives under `ipc_fuzzer/replay`. The renderer is replaced with
55+
`ipc_fuzzer_replay` using `--renderer-cmd-prefix`. This is done automatically
56+
with the `ipc_fuzzer/play_testcase.py` convenience script.
57+
58+
### ipcdump mutator / generator
59+
60+
Lives under `ipc_fuzzer/fuzzer`. This is the code that runs on ClusterFuzz. It
61+
uses `FuzzTraits<Type>` to mutate ipcdumps or generate them out of thin air.
62+
63+
## Problems, questions, suggestions
64+
65+
Send them to [email protected].

0 commit comments

Comments
 (0)