Skip to content

Commit f73f0df

Browse files
bratell-at-operaCommit Bot
authored and
Commit Bot
committed
Remove references to gyp from DEPS and docs
Bug: 826218 Change-Id: I176e1aeb0b24b21c6b4e5ee40910dce2bce52c95 Reviewed-on: https://chromium-review.googlesource.com/1239461 Reviewed-by: Nico Weber <[email protected]> Commit-Queue: Daniel Bratell <[email protected]> Cr-Commit-Position: refs/heads/master@{#593522}
1 parent 49bd0e6 commit f73f0df

19 files changed

+30
-111
lines changed

docs/android_test_instructions.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,7 @@ for example, `content_junit_tests` and `chrome_junit_tests`.
158158

159159
When adding a new JUnit test, the associated `BUILD.gn` file must be updated.
160160
For example, adding a test to `chrome_junit_tests` requires to update
161-
`chrome/android/BUILD.gn`. If you are a GYP user, you will not need to do that
162-
step in order to run the test locally but it is still required for GN users to
163-
run the test.
161+
`chrome/android/BUILD.gn`.
164162

165163
```shell
166164
# Build the test suite.

docs/angle_in_chromium.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ Clone the ANGLE git repository.
2323
> gclient runhooks
2424
```
2525

26-
To check ANGLE builds (assumes you ran hooks with GYP\_GENERATORS=ninja) without
27-
building all of Chromium.
26+
To check ANGLE builds without building all of Chromium.
2827

2928
```shell
3029
ninja -C out\Release libEGL.dll

docs/ccache_mac.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ git clone git://git.samba.org/ccache.git cd ccache
3636
Make sure ccache can be found in your `$PATH`.
3737

3838
You can also just use the current released version of ccache (3.1.8 or 3.1.9)
39-
and disable the chromium style plugin with `clang_use_chrome_plugins=0` in your
40-
`GYP_DEFINES`.
39+
and disable the chromium style plugin with `clang_use_chrome_plugins = false`
40+
in your args.gn.
4141

4242
## Use with GN
4343

docs/eclipse.md

-18
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,6 @@ settings below are inside Window > Preferences.
5959
* Disable build before launching
6060
* Select Run/Debug > Launching
6161
* Uncheck Build (if required) before launching
62-
* File types for .gyp and .gypi
63-
* Go to General > Editors > File Associations
64-
* Add `*.gyp` and `*.gypi` file types, and associate them with Python Editor
65-
* See http://pydev.org/index.html for instructions on getting a Python
66-
Editor configured in Eclipse
67-
* Enjoy a happy life with Ctrl+Shift+P and automatic matching bracket
68-
highlight.
6962
* Tab ordering
7063
* If you prefer ordering your tabs by most recently used, go to General >
7164
Appearance and check Show most recently used tabs
@@ -122,17 +115,6 @@ settings below are inside Window > Preferences.
122115
* Uncheck Index source files not included in the build
123116
* Uncheck Allow heuristic resolution of includes
124117
* Click Apply to commit the changes
125-
* C/C++ Paths and Symbols. This help Eclipse build the symbol table for Chrome.
126-
* From a shell, run `GYP_GENERATORS=eclipse build/gyp_chromium`
127-
* This generates `<project root>/out/Release/eclipse-cdt-settings.xml` which
128-
is used below.
129-
* Select C/C++ General > Paths and Symbols from the tree on the left
130-
* Click Restore Defaults to clear any old settings
131-
* Click Import Settings... The import dialog should appear.
132-
* Click Browse... A file browser should appear.
133-
* Select `<project root>/out/Release/eclipse-cdt-settings.xml`.
134-
* Click the Finish button. The entire preferences dialog should go away.
135-
* Right click on the project and select Index > Rebuild
136118
* Java
137119
* Create a link from `<project root>/.classpath` to
138120
`<project root>/tools/android/eclipse/.classpath`:

docs/emacs.md

+1-15
Original file line numberDiff line numberDiff line change
@@ -187,21 +187,7 @@ One nice way to highlight long lines and other style issues:
187187
Note: You might need to grab the latest version of
188188
[whitespace.el](http://www.emacswiki.org/emacs-en/download/whitespace.el).
189189
190-
## gyp
191-
192-
### `gyp` style
193-
There is a gyp mode that provides basic indentation and font-lock (syntax
194-
highlighting) support. The mode derives from python.el (bundled with newer
195-
emacsen).
196-
197-
You can find it in /src/tools/gyp/tools/emacs
198-
199-
See the README file there for installation instructions.
200-
201-
**Important**: the mode is only tested with `python.el` (bundled with newer
202-
emacsen), not with `python-mode.el` (outdated and less maintained these days).
203-
204-
### deep nesting
190+
## deep nesting
205191
206192
A couple of helpers that show a summary of where you are; the first by tracing
207193
the indentation hierarchy upwards, the second by only showing `#if`s and

docs/gpu/debugging_gpu_related_code.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ glPopGroupMarkerEXT(); // -> log prefix = "Foo.That"
8888
You can often make a simple OpenGL-ES-2.0-only C++ reduced test case that is
8989
relatively quick to compile and test, by adding tests to the `gl_tests` target.
9090
Those tests exist in `src/gpu/command_buffer/tests` and are made part of the
91-
build in `src/gpu/gpu.gyp`. Build with `ninja -C out/Debug gl_tests`. All the
91+
build in `src/gpu/BUILD.gn`. Build with `ninja -C out/Debug gl_tests`. All the
9292
same command line options listed on this page will work with the `gl_tests`,
9393
plus `--gtest_filter=NameOfTest` to run a specific test. Note the `gl_tests`
9494
are not multi-process, so they probably won't help with race conditions, but

docs/gpu/gpu_testing.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ single step.
422422
If you are adding a new test to one of the existing tests (e.g., `pixel_test`),
423423
all you need to do is make sure that your new test runs correctly via isolates.
424424
See the documentation from the GPU bot details on [adding new isolated
425-
tests][new-isolates] for the `GYP_DEFINES` and authentication needed to upload
425+
tests][new-isolates] for the gn args and authentication needed to upload
426426
isolates to the isolate server. Most likely the new test will be Telemetry
427427
based, and included in the `telemetry_gpu_test_run` isolate. You can then
428428
invoke it via:

docs/gpu/pixel_wrangling.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,11 @@ test the code that is actually shipped. As of this writing, the tests included:
8383
`pixel_integration_test.py`
8484
* Stress tests of the screenshot functionality other tests use:
8585
`screenshot_sync_integration_test.py`
86-
* `angle_unittests`: see `src/gpu/gpu.gyp`
86+
* `angle_unittests`: see `src/third_party/angle/src/tests/BUILD.gn`
8787
* drawElements tests (on the chromium.gpu.fyi waterfall): see
8888
`src/third_party/angle/src/tests/BUILD.gn`
8989
* `gles2_conform_test` (requires internal sources): see
90-
`src/gpu/gles2_conform_support/gles2_conform_test.gyp`
90+
`src/gpu/gles2_conform_support/BUILD.gn`
9191
* `gl_tests`: see `src/gpu/BUILD.gn`
9292
* `gl_unittests`: see `src/ui/gl/BUILD.gn`
9393

docs/ipc_fuzzer.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ contribute.
1313

1414
### Build instructions
1515

16-
* Run `gn args` and add `enable_ipc_fuzzer = true` to your args.gn. If you use
17-
GYP, add `enable_ipc_fuzzer=1` to `GYP_DEFINES`.
16+
* Run `gn args` and add `enable_ipc_fuzzer = true` to your args.gn.
1817
* build `ipc_fuzzer_all` target
1918
* component builds are currently broken, sorry
2019
* Debug builds are broken; only Release mode works.
@@ -43,7 +42,7 @@ contribute.
4342

4443
### ipcdump logger
4544

46-
* add `enable_ipc_fuzzer=1` to `GYP_DEFINES`
45+
* add `enable_ipc_fuzzer = true` to `args.gn`
4746
* build `chrome` and `ipc_message_dump` targets
4847
* run chrome with
4948
`--no-sandbox --ipc-dump-directory=/path/to/ipcdump/directory`

docs/linux_chromium_arm.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ and library dependencies directly from Ubuntu:
2323
### Installing the sysroot
2424

2525
A prebuilt sysroot image is kept up to date on Cloud Storage. It will
26-
automatically be installed by gclient runhooks installed if you have
27-
`target_arch=arm` in your `GYP_DEFINES`.
26+
automatically be installed by gclient runhooks if `target_cpu=["arm"]`
27+
is present in your `.gclient` file.
2828

2929
To install the sysroot manually you can run:
3030

docs/linux_debugging.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -458,9 +458,7 @@ with the appropriate instructions if you know what they are.)
458458

459459
## Breakpad
460460

461-
See the last section of [Linux Crash Dumping](linux_crash_dumping.md); you
462-
need to set a gyp variable and an environment variable for the crash dump tests
463-
to work.
461+
See the last section of [Linux Crash Dumping](linux_crash_dumping.md).
464462

465463
## Drag and Drop
466464

docs/linux_hw_video_decode.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ on a gprecise setup.
4747
make -j32 && rm -f ${DEST}/lib/dri/{nvidia_drv_video.so,s3g_drv_video.so} && make install
4848
```
4949

50-
* Add to `$GYP_DEFINES`:
51-
* `chromeos=1` to link in `VaapiVideoDecodeAccelerator`
52-
* `proprietary_codecs=1 ffmpeg_branding=Chrome` to allow Chrome to play
53-
h.264 content, which is the only codec VAVDA knows about today.
54-
* Re-run gyp (`./build/gyp_chromium` or `gclient runhooks`)
50+
* Add to args.gn:
51+
* `target_os = "chromeos"` to link in `VaapiVideoDecodeAccelerator`
52+
* `proprietary_codecs = true` and `ffmpeg_branding = "Chrome"` to
53+
allow Chrome to play h.264 content, which is the only codec
54+
VAVDA knows about today.
5555
* Rebuild chrome
5656
* Run chrome with `LD_LIBRARY_PATH=${HOME}/apps/libva/lib` in the environment,
5757
and with the `--no-sandbox` command line flag.

docs/linux_profiling.md

+2-7
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,11 @@ This will use the previously captured data (`perf.data`).
5555

5656
### google-perftools
5757

58-
google-perftools code is enabled when the `use_allocator` variable in gyp is set
58+
google-perftools code is enabled when the `use_allocator` gn variable is set
5959
to `tcmalloc` (currently the default). That will build the tcmalloc library,
6060
including the cpu profiling and heap profiling code into Chromium. In order to
6161
get stacktraces in release builds on 64 bit, you will need to build with some
62-
extra flags enabled by setting `profiling=1` in gyp.
63-
64-
If the stack traces in your profiles are incomplete, this may be due to missing
65-
frame pointers in some of the libraries. A workaround is to use the
66-
`linux_keep_shadow_stacks=1` gyp option. This will keep a shadow stack using the
67-
`-finstrument-functions` option of gcc and consult the stack when unwinding.
62+
extra flags enabled by setting `enable_profiling = true` in args.gn
6863

6964
In order to enable cpu profiling, run Chromium with the environment variable
7065
`CPUPROFILE` set to a filename. For example:

docs/linux_suid_sandbox_development.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,4 @@ You can also make such an installation more permanent by following the
8383
8484
The `CHROME_DEVEL_SANDBOX` variable is intended for developers and won't work
8585
for a system-wide installation of Chromium. Package maintainers should make sure
86-
the `setuid` binary is installed and defined in GYP as `linux_sandbox_path`.
86+
the `setuid` binary is installed.

docs/memory-infra/README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,8 @@ contextual data:
140140
event? Which subsystem increased? Did memory not go down as expected after
141141
closing a tab? Which other threads were active during a bloat?
142142
* **Works out of the box on desktop and mobile.**
143-
No recompilations with unmaintained `GYP_DEFINES`, no time-consuming
144-
symbolizations stages. All the logic is already into Chrome, ready to dump at
145-
any time.
143+
No recompilations, no time-consuming symbolizations stages. All the
144+
logic is already in Chrome, ready to dump at any time.
146145
* **The same technology is used for telemetry and the ChromePerf dashboard.**
147146
See [the slides][chromeperf-slides] and take a look at
148147
[some ChromePerf dashboards][chromeperf] and

docs/using_a_linux_chroot.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ chroot.
1616
Run `build /install-build-deps.sh`, then exit the rooted chroot.
1717
* Delete your out/ directory if you had a previous non-chrooted build.
1818
* To enter your chroot as normal user, run `schroot -c lucid64`.
19-
* Now run `build/gyp_chromium`, compile and run DumpRenderTree within chroot.
19+
* Now compile and run DumpRenderTree within chroot.
2020

2121
## Tips and Tricks
2222

docs/vanilla_msysgit_workflow.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,10 @@ switching between branches):
7373
you use my naming convention or not), you can know before hand when you
7474
switch between branches on Windows whether you should expect a major
7575
rebuild, or a minor rebuild. If you are able to remember which of your
76-
topic branches have .gyp changes and which don't (or I guess you could use
76+
topic branches have gn changes and which don't (or I guess you could use
7777
`git diff` to figure this out), then you will also have a good idea whether
7878
you need to run `gclient runhooks` or not when you switch branches. Another
79-
nice thing is that yu should never have to run `gclient sync` when you
79+
nice thing is that you should never have to run `gclient sync` when you
8080
switch between branches with the same base revision, unless some of your
8181
branches have changes to DEPS files.
8282

docs/windows_split_dll.md

+3-39
Original file line numberDiff line numberDiff line change
@@ -5,37 +5,10 @@ undertaken as one possible workaround for toolchain limitations on Windows.
55

66
## How
77

8-
Normally, you probably don't need to worry about doing this build. If for some
9-
reason you need to build it locally:
8+
Split DLL is now default on Windows and controlled by the
9+
`is_multi_dll_chrome` gn variable.
1010

11-
1. From a _Visual Studio Command Prompt_ running as **Administrator** run
12-
`python tools\win\split_link\install_split_link.py`.
13-
1. Set `GYP_DEFINES=chrome_split_dll=1`. In particular, don't have
14-
`component=shared_library`. Other things, like `buildtype` or `fastbuild`
15-
are fine.
16-
1. `gclient runhooks`
17-
1. `ninja -C out\Release chrome`
18-
19-
`chrome_split_dll` currently applies only to chrome.dll (and not test binaries).
20-
21-
## What
22-
23-
This is intended to be a temporary measure until either the toolchain is
24-
improved or the code can be physically separated into two DLLs (based on a
25-
browser/child split).
26-
27-
The link replacement forcibly splits chrome.dll into two halves based on a
28-
description in `build\split_link_partition.py`. Code is primarily split along
29-
browser/renderer lines. Roughly, Blink and its direct dependencies are in the
30-
"chrome1.dll", and the rest of the browser code remains in "chrome.dll".
31-
32-
TODO: build\split_link_partition.py doesn't exist.
33-
34-
Splitting the code this way allows keeping maximum optimization on the Blink
35-
portion of the code, which is important for performance.
36-
37-
There is a compile time define set when building in this mode
38-
`CHROME_SPLIT_DLL`, however it should be used very sparingly-to-not-at-all.
11+
`is_multi_dll_chrome` applies only to chrome.dll (and not test binaries).
3912

4013
## Details
4114

@@ -44,15 +17,6 @@ the other, and causing unresolved externals that result during linking to be
4417
forcibly exported from the other DLL. This works relatively cleanly for function
4518
import/export, however it cannot work for data export.
4619

47-
There are relatively few instances where data exports are required across the
48-
DLL boundary. The waterfall builder
49-
https://build.chromium.org/p/chromium/waterfall?show=Win%20Split will detect when
50-
new data exports are added, and these will need to be repaired. For constants,
51-
the data can be duplicated to both DLLs, but for writeable data, a wrapping
52-
set/get function will need to be added.
53-
54-
https://build.chromium.org/p/chromium/waterfall?show=Win%20Split does not exist.
55-
5620
Some more details can be found on the initial commit of the split_link script
5721
https://src.chromium.org/viewvc/chrome?revision=200049&view=revision and the
5822
associated bugs: https://crbug.com/237249 https://crbug.com/237267.

tools/DEPS

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# checkdeps.py shouldn't check include paths for files in these dirs:
22
skip_child_includes = [
33
"clang",
4-
"gyp",
54
"traceline",
65
"perf/page_sets",
76
]

0 commit comments

Comments
 (0)