Remove act from around testing-library async clicks (#3856)

Author: imnasnainaec

src/components/Login/tests/Login.test.tsx

@@ -1,6 +1,5 @@
-import { render, screen } from "@testing-library/react";
+import { act, render, screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
-import { act } from "react";
 import { Provider } from "react-redux";
 import configureMockStore from "redux-mock-store";
 
@@ -47,7 +46,7 @@ const typeInField = async (id: LoginId, value: string): Promise<void> => {
 /** Click the Login button and confirm whether the field with the given ID has an error. */
 const loginAndCheckError = async (errorId?: LoginId): Promise<void> => {
   // Login button click
-  await act(async () => screen.getByTestId(LoginId.ButtonLogIn).click());
+  await userEvent.click(screen.getByTestId(LoginId.ButtonLogIn));
 
   // Username field check
   const userLabel = screen.getByText(LoginTextId.LabelUsername);

src/components/Login/tests/Signup.test.tsx

@@ -1,6 +1,5 @@
-import { render, screen } from "@testing-library/react";
+import { act, render, screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
-import { act } from "react";
 import { Provider } from "react-redux";
 import configureMockStore from "redux-mock-store";
 
@@ -75,7 +74,7 @@ const typeInFields = async (textRecord: Partial<SignupText>): Promise<void> => {
 /** Clicks the submit button and checks that only the specified field errors. */
 const submitAndCheckError = async (id?: SignupField): Promise<void> => {
   // Submit the form.
-  await act(async () => screen.getByTestId(SignupId.ButtonSignUp).click());
+  await userEvent.click(screen.getByTestId(SignupId.ButtonSignUp));
 
   // Only the specified field should error.
   Object.values(SignupField).forEach((val) => {

src/components/ProjectUsers/tests/SpeakerConsentListItemIcon.test.tsx

@@ -79,9 +79,7 @@ describe("SpeakerConsentListItemIcon", () => {
       expect(screen.queryByTestId(ListItemIconId.RecordAudio)).toBeNull();
       expect(screen.queryByTestId(ListItemIconId.UploadAudio)).toBeNull();
 
-      await act(async () => {
-        await agent.click(screen.getByRole("button"));
-      });
+      await agent.click(screen.getByRole("button"));
       expect(screen.queryByRole("menu")).not.toBeNull();
       expect(screen.queryByTestId(ListItemIconId.RecordAudio)).not.toBeNull();
       expect(screen.queryByTestId(ListItemIconId.UploadAudio)).not.toBeNull();
@@ -119,9 +117,7 @@ describe("SpeakerConsentListItemIcon", () => {
       });
       expect(screen.queryByRole("dialog")).toBeNull();
 
-      await act(async () => {
-        await agent.click(screen.getByRole("button"));
-      });
+      await agent.click(screen.getByRole("button"));
       expect(screen.queryByRole("dialog")).not.toBeNull();
     });
   });